Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export newUnameCollector function in uname.go #3227

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Export newUnameCollector function in uname.go #3227

merged 1 commit into from
Jan 25, 2025

Conversation

orloffv
Copy link
Contributor

@orloffv orloffv commented Jan 16, 2025 •
edited
Loading

Rename newUnameCollector to NewUnameCollector in collector/uname.go.

  • Export NewUnameCollector to make it accessible outside the package

@orloffv orloffv force-pushed the export-newunamecollector branch from 73d1d7d to 908fc20 Compare January 16, 2025 13:23
SuperQ
SuperQ approved these changes Jan 25, 2025
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks like only a few collectors are missing this exporting. Any chance you want to fix the remaining ones?

@SuperQ SuperQ merged commit 810510e into prometheus:master Jan 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orloffv @SuperQ