Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Printer pages counters #1353

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add Printer pages counters #1353

wants to merge 3 commits into from
+25 −0

Conversation

eflumerf
Copy link

@eflumerf eflumerf commented Feb 3, 2025

@bastischubert
Copy link
Member

Hey @eflumerf thanks for your contribution !
to accept this PR please sign the commit and also include the updated snmp.yml.

@eflumerf
Copy link
Author

eflumerf commented Feb 4, 2025

Done!

@bastischubert
Copy link
Member

thx for fixing - can you please sign off the commits (see https://github.com/prometheus/snmp_exporter/pull/1353/checks?check_run_id=36656171662 ) then we should be ready to merge

@SuperQ
Copy link
Member

SuperQ commented Feb 6, 2025

This needs a DCO sign-off. You can use git commit -s --amend to add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eflumerf @bastischubert @SuperQ