-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace load-generator with Go implementation #725
Conversation
@SuperQ Sir, can you please check it once? |
tools/load-generator/Dockerfile
Outdated
WORKDIR /usr/src/app | ||
COPY . . | ||
|
||
RUN go build -o load-generator . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't do builds in Docker here. What you want to do is add the new tool to the top level .promu.yml
. Take a look at tools/fake-webserver/Dockerfile
for an example.
This needs a DCO sign-off. You can use |
@SuperQ Sir first of all really sorry for not clarifying properly about PR, yes it resolved 2 issues this one and #705. I have a seperate PR for #705 as well but no was reviewing it. Also the changes you suggested I will make in few hour and commit changes, and will see why tests are failing, and try to resolve it. |
We generally don't review if tests are failing. |
Signed-off-by: HARSHIT NAGPAL <[email protected]>
7affdaf
to
30350d6
Compare
@SuperQ Sir i have made the changes as suggested by you, PTAl. |
i dont know why DCO is failing even after git commit -s --amend |
Each individual commit must be signed off. You can use |
@SuperQ Sir can I close this PR? and you can merge another one, is it fine? |
Superseded by #748 |
Fixes #688
Fixes #705