Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace load-generator with Go implementation #725

Closed
wants to merge 4 commits into from

Conversation

HarshitNagpal29
Copy link

@HarshitNagpal29 HarshitNagpal29 commented Aug 27, 2024

  • Replace python load-generator with a Go implementation.
  • Add additional PromQL tests.

Fixes #688
Fixes #705

@HarshitNagpal29
Copy link
Author

@SuperQ Sir, can you please check it once?

WORKDIR /usr/src/app
COPY . .

RUN go build -o load-generator .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't do builds in Docker here. What you want to do is add the new tool to the top level .promu.yml. Take a look at tools/fake-webserver/Dockerfile for an example.

.github/dependabot.yml Outdated Show resolved Hide resolved
tools/load-generator/main.go Outdated Show resolved Hide resolved
@SuperQ
Copy link
Member

SuperQ commented Aug 30, 2024

This needs a DCO sign-off. You can use git commit -s --amend to add it.

@SuperQ SuperQ changed the title PR for #688 and #705 Replace load-generator with Go implementation Aug 30, 2024
@HarshitNagpal29
Copy link
Author

@SuperQ Sir first of all really sorry for not clarifying properly about PR, yes it resolved 2 issues this one and #705. I have a seperate PR for #705 as well but no was reviewing it.

Also the changes you suggested I will make in few hour and commit changes, and will see why tests are failing, and try to resolve it.

@SuperQ
Copy link
Member

SuperQ commented Aug 30, 2024

We generally don't review if tests are failing.

@HarshitNagpal29
Copy link
Author

HarshitNagpal29 commented Aug 30, 2024

Also sir can you look for issue #594 once, like I have proposed it's solution and not created PR, I have mentioned everything there once you can check I have ready solution in python I will create it in go aswell.
@SuperQ

@HarshitNagpal29
Copy link
Author

@SuperQ Sir i have made the changes as suggested by you, PTAl.

@HarshitNagpal29
Copy link
Author

i dont know why DCO is failing even after git commit -s --amend

@SuperQ
Copy link
Member

SuperQ commented Aug 31, 2024

Each individual commit must be signed off. You can use git rebase -i origin/master to squash your commits.

@SuperQ SuperQ requested a review from gouthamve August 31, 2024 13:09
@HarshitNagpal29
Copy link
Author

@SuperQ Hi Sir, hope you are doing well, I was having multiple issues even after rebasing so I have created a new PR #743 signing and it has passed DCO, please review and approve the changes.

@HarshitNagpal2901
Copy link
Contributor

@SuperQ Sir can I close this PR? and you can merge another one, is it fine?

@SuperQ
Copy link
Member

SuperQ commented Sep 21, 2024

Superseded by #748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PromBench Idea: exercise more parts of PromQL Rewrite load-generator in Go
3 participants