Tests: Speedup local execution

tests/Propel/Tests/Generator/Command/MigrationTest.php

@@ -26,6 +26,23 @@
  */
 class MigrationTest extends TestCaseFixturesDatabase
 {
+
+    /**
+     * Directory with default connection (can be any, schema.xml files use a
+     * schema prefix for tables, so initial connection does not matter)
+     *
+     * @var string
+     */
+    private const CONNECTION_CONFIG_DIR = __DIR__ . '/../../../../Fixtures/migration';
+
+    /**
+     * Used when retrieving connection by name
+     * (can be any, same as CONNECTION_CONFIG_DIR)
+     *
+     * @var string
+     */
+    private const DATABASE_NAME = 'migration';
+
     /**
      * @var bool
      */
@@ -34,7 +51,7 @@ class MigrationTest extends TestCaseFixturesDatabase
     /**
      * @var string
      */
-    private const SCHEMA_DIR = __DIR__ . '/../../../../Fixtures/migration-command';
+    private const BASE_SCHEMA_DIR = __DIR__ . '/util/migrate-to-version/base';
 
     /**
      * @var string
@@ -44,7 +61,7 @@ class MigrationTest extends TestCaseFixturesDatabase
     /**
      * @var string
      */
-    private const SCHEMA_DIR_MIGRATE_TO_VERSION = __DIR__ . '/../../../../Fixtures/migrate-to-version';
+    private const SCHEMA_DIR_MIGRATE_TO_VERSION_PATTERN = __DIR__ . '/util/migrate-to-version/version-*';
 
     /**
      * @see \Propel\Generator\Command\MigrationMigrateCommand::COMMAND_OPTION_MIGRATE_TO_VERSION
@@ -78,7 +95,7 @@ class MigrationTest extends TestCaseFixturesDatabase
     public function testDiffCommandCreatesFiles(): void
     {
         $this->deleteMigrationFiles();
-        $this->runCommandAndAssertSuccess('migration:diff', new MigrationDiffCommand(), ['--schema-dir' => self::SCHEMA_DIR]);
+        $this->runCommandAndAssertSuccess('migration:diff', new MigrationDiffCommand(), ['--schema-dir' => self::BASE_SCHEMA_DIR]);
         $this->assertGeneratedFileContainsCreateTableStatement(true, 'PropelMigration_*.php');
     }
 
@@ -89,7 +106,7 @@ public function testDiffCommandCreatesSuffixedFiles(): void
     {
         $this->deleteMigrationFiles();
         $suffix = 'an_explanatory_filename_suffix';
-        $this->runCommandAndAssertSuccess('migration:diff', new MigrationDiffCommand(), ['--schema-dir' => self::SCHEMA_DIR, '--suffix' => $suffix]);
+        $this->runCommandAndAssertSuccess('migration:diff', new MigrationDiffCommand(), ['--schema-dir' => self::BASE_SCHEMA_DIR, '--suffix' => $suffix]);
         $this->assertGeneratedFileContainsCreateTableStatement(true, "PropelMigration_*_$suffix.php");
     }
 
@@ -99,7 +116,7 @@ public function testDiffCommandCreatesSuffixedFiles(): void
     public function testCreateCommandCreatesFiles(): void
     {
         $this->deleteMigrationFiles();
-        $this->runCommandAndAssertSuccess('migration:create', new MigrationCreateCommand(), ['--schema-dir' => self::SCHEMA_DIR]);
+        $this->runCommandAndAssertSuccess('migration:create', new MigrationCreateCommand(), ['--schema-dir' => self::BASE_SCHEMA_DIR]);
         $this->assertGeneratedFileContainsCreateTableStatement(false, 'PropelMigration_*.php');
     }
 
@@ -110,7 +127,7 @@ public function testCreateCommandCreatesSuffixedFiles(): void
     {
         $this->deleteMigrationFiles();
         $suffix = 'an_explanatory_filename_suffix';
-        $this->runCommandAndAssertSuccess('migration:create', new MigrationCreateCommand(), ['--schema-dir' => self::SCHEMA_DIR, '--suffix' => $suffix]);
+        $this->runCommandAndAssertSuccess('migration:create', new MigrationCreateCommand(), ['--schema-dir' => self::BASE_SCHEMA_DIR, '--suffix' => $suffix]);
         $this->assertGeneratedFileContainsCreateTableStatement(false, "PropelMigration_*_$suffix.php");
     }
 
@@ -379,11 +396,11 @@ private function buildApplicationInputArguments(string $commandName, array $addi
     {
         $additionalArguments['command'] = $commandName;
 
-        $dsn = $this->getConnectionDsn('bookstore', true);
+        $dsn = $this->getConnectionDsn(static::DATABASE_NAME, true);
         $connectionOption = ['migration_command=' . $dsn];
 
         $defaultAppArguments = [
-            '--config-dir' => self::SCHEMA_DIR,
+            '--config-dir' => self::CONNECTION_CONFIG_DIR,
             '--output-dir' => self::OUTPUT_DIR,
             '--platform' => ucfirst($this->getDriver()) . 'Platform',
             '--connection' => $connectionOption,
@@ -434,26 +451,22 @@ private function assertIsCurrentVersion(int $version): void
     }
 
     /**
+     * Creates migratoins according to the schemas in the folders
+     * ./util/migrate-to-version/version-* and applies them.
+     * 
      * @return void
      */
     private function setUpMigrateToVersion(): void
     {
         $this->deleteMigrationFiles();
 
         /** @var array<string> $versionDirectories */
-        $versionDirectories = glob(
-            sprintf(
-                '%s%s*',
-                self::SCHEMA_DIR_MIGRATE_TO_VERSION,
-                DIRECTORY_SEPARATOR,
-            ),
-            GLOB_ONLYDIR,
-        );
+        $versionDirectories = glob(self::SCHEMA_DIR_MIGRATE_TO_VERSION_PATTERN, GLOB_ONLYDIR);
 
         foreach ($versionDirectories as $versionDirectory) {
             $this->runCommand('migration:diff', new MigrationDiffCommand(), ['--schema-dir' => $versionDirectory]);
             $this->migrateUp();
-            sleep(1);
+            time_nanosleep(1, 0); // sleep one second to ensure distinct timestamps on migration files
         }
     }
 

tests/Fixtures/migration-command/schema.xml → tests/Propel/Tests/Generator/Command/util/migrate-to-version/base/schema.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="ISO-8859-1" standalone="no"?>
-<database name="migration_command">
+<database name="migration_command" schema="migration_command_db">
 
     <table name="table1">
         <column name="id" required="true" primaryKey="true" autoIncrement="true" type="INTEGER" description="Book Id"/>

tests/Fixtures/migrate-to-version/version-1/schema.xml → tests/Propel/Tests/Generator/Command/util/migrate-to-version/version-1/schema.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="ISO-8859-1" standalone="no"?>
-<database name="migration_command">
+<database name="migration_command" schema="migration_command_db">
 
     <table name="table1">
         <column name="id" required="true" primaryKey="true" autoIncrement="true" type="INTEGER" description="Book Id"/>

tests/Fixtures/migrate-to-version/version-2/schema.xml → tests/Propel/Tests/Generator/Command/util/migrate-to-version/version-2/schema.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="ISO-8859-1" standalone="no"?>
-<database name="migration_command">
+<database name="migration_command" schema="migration_command_db">
 
     <table name="table1">
         <column name="id" required="true" primaryKey="true" autoIncrement="true" type="INTEGER" description="Book Id"/>

tests/Fixtures/migrate-to-version/version-3/schema.xml → tests/Propel/Tests/Generator/Command/util/migrate-to-version/version-3/schema.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="ISO-8859-1" standalone="no"?>
-<database name="migration_command">
+<database name="migration_command" schema="migration_command_db">
 
     <table name="table1">
         <column name="id" required="true" primaryKey="true" autoIncrement="true" type="INTEGER" description="Book Id"/>

tests/Propel/Tests/Generator/Platform/DefaultPlatformTest.php

@@ -194,4 +194,12 @@ public function testGetColumnBindingPHP($column, $default)
     {
         $this->assertStringContainsString($default, $this->getPlatform()->getColumnBindingPHP($column, 'ID', 'ACCESSOR'));
     }
+
+    /**
+     * @return void
+     */
+    public function testDoesNotSupportNativeOnDeleteTriggers()
+    {
+        $this->assertFalse($this->getPlatform()->supportsNativeDeleteTrigger());
+    }
 }

tests/bin/setup.mysql.bat

@@ -37,6 +37,7 @@ DROP SCHEMA IF EXISTS second_hand_books;^
 DROP SCHEMA IF EXISTS contest;^
 DROP SCHEMA IF EXISTS bookstore_schemas;^
 DROP SCHEMA IF EXISTS migration;^
+DROP SCHEMA IF EXISTS migration_command_db;^
 SET FOREIGN_KEY_CHECKS = 1;^
 "
 call %DIR%\base.bat :check
@@ -49,6 +50,7 @@ CREATE SCHEMA bookstore_schemas;^
 CREATE SCHEMA contest;^
 CREATE SCHEMA second_hand_books;^
 CREATE SCHEMA migration;^
+CREATE SCHEMA migration_command_db;^
 "
 call %DIR%\base.bat :check
 if "%errorlevel%" == "1" exit /B 1

tests/bin/setup.mysql.sh

@@ -30,6 +30,7 @@ DB_PORT=${DB_PORT-3306};
     DROP SCHEMA IF EXISTS contest;
     DROP SCHEMA IF EXISTS bookstore_schemas;
     DROP SCHEMA IF EXISTS migration;
+    DROP SCHEMA IF EXISTS migration_command_db;
     SET FOREIGN_KEY_CHECKS = 1;
     " || exit 1;
 
@@ -41,6 +42,7 @@ DB_PORT=${DB_PORT-3306};
     CREATE SCHEMA contest;
     CREATE SCHEMA second_hand_books;
     CREATE SCHEMA migration;
+    CREATE SCHEMA migration_command_db;
     " || exit 1;
 ) || exit 1;
 

tests/bin/setup.pgsql.bat

@@ -41,6 +41,7 @@ CREATE SCHEMA bookstore_schemas;^
 CREATE SCHEMA contest;^
 CREATE SCHEMA second_hand_books;^
 CREATE SCHEMA migration;^
+CREATE SCHEMA migration_command_db;^
 " "%DB_NAME%"
 
 call %DIR%\base.bat :check

tests/bin/setup.pgsql.sh

@@ -16,7 +16,7 @@ if [ "$DB_NAME" = "" ]; then
 fi
 
 DB_HOSTNAME=${DB_HOSTNAME-127.0.0.1};
-DB_PW=${DB_PW-$PGPASSWORD};.0.1};
+DB_PW=${DB_PW-$PGPASSWORD};
 DB_PORT=${DB_PORT-5432};
 
 if [ -z "$DB_PW" ]; then
@@ -40,6 +40,7 @@ fi
     CREATE SCHEMA contest;
     CREATE SCHEMA second_hand_books;
     CREATE SCHEMA migration;
+    CREATE SCHEMA migration_command_db;
     ' "$DB_NAME" >/dev/null;
 ) || exit 1;