[proptest-macro] add the ability to specify custom strategies #523
Conversation
| Meta::NameValue(_) => { | ||
| if first_strategy_seen { | ||
| error.extend(quote_spanned! { | ||
| attr.span() => compile_error!("duplicate `#[strategy = ...]` definition"); |
There was a problem hiding this comment.
may be worth saying the name of the parameter here for added clarity
| snapshot_test!(custom_strategy { | ||
| fn foo( | ||
| #[strategy = 123] x: i32, | ||
| #[strategy = a + more()("complex") - expression!()] y: String, |
There was a problem hiding this comment.
this is really cool that one can just assign a literal if needed. i'm curious about y here though, like what happens if an operator that cannot be used on string types is used? I guess that question may reduce down to, what happens if the strategies type does not match the type of the parameter, will the type error be relatively obvious for the user?
There was a problem hiding this comment.
also do we expect argument types to ever use lifetimes or generics? what happens if someone tries to and should we test for that?
There was a problem hiding this comment.
had a few questions but overall this looks great to me and happy to move forward with it! (assuming ci is 💚 after running)
also just to weigh in a comment from the original pr
I think for now, disallowing other attributes is safer from a backwards compatibility point of view - we don't lock ourselves into supporting something that is difficult later
i think i agree with taking a conservative/iterative stance here
replaces #478