Add missing code on mypy errors #721
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is dmypy usefull? |
Use mypy api to get the messages details before: ``` prospector/blender.py:81:13: error(mypy): List comprehension has incompatible type List[Message]; expected List[str] [misc] prospector/blender.py:101:12: error(mypy): Incompatible return value type (got "list[str]", expected "list[Message]") [return-value] ``` after: ``` prospector/blender.py:81:12: misc(mypy): List comprehension has incompatible type List[Message]; expected List[str]. prospector/blender.py:101:11: return-value(mypy): Incompatible return value type (got "list[str]", expected "list[Message]"). ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use mypy api to get the messages details
before:
after:
Description
Use the json formater, use the API to get the message individually.
Related Issue
fix #716
Motivation and Context
Have a better mypy integration
How Has This Been Tested?
Run on Prospector code with some errors
Types of changes