Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also check Python scripts with a valid shebang #732

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Mar 7, 2025

Description

Also check Python scripts with a valid shebang

Motivation and Context

Be able to check the Python scripts that didn't end with .py.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@sbrunner sbrunner force-pushed the check-scripts branch 6 times, most recently from 87e0930 to 97a0c7e Compare March 7, 2025 17:13
@sbrunner sbrunner marked this pull request as ready for review March 7, 2025 17:21
Copy link
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might want to add a bunch of test files with various shebang to test it maybe ?

@@ -0,0 +1,90 @@
# Largely inspied by https://github.com/pre-commit/identify/blob/main/identify/identify.py#L178
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Largely inspied by https://github.com/pre-commit/identify/blob/main/identify/identify.py#L178
# Largely inspired by https://github.com/pre-commit/identify/blob/main/identify/identify.py#L178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants