Replace enums to be extendable #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CandiedCode
reviewed
May 23, 2024
Comment on lines
+8
to
+20
| class Property: | ||
| def __init__(self, name: str, value: Any) -> None: | ||
| self.name = name | ||
| self.value = value | ||
|
|
||
|
|
||
| class SupportedModelFormats: | ||
| TENSORFLOW = Property("TENSORFLOW", "tensorflow") | ||
| KERAS_H5 = Property("KERAS_H5", "keras_h5") | ||
| KERAS = Property("KERAS", "keras") | ||
| NUMPY = Property("NUMPY", "numpy") | ||
| PYTORCH = Property("PYTORCH", "pytorch") | ||
| PICKLE = Property("PICKLE", "pickle") |
There was a problem hiding this comment.
Enum already supports name and value.
I'd recommend adding support for str, if you want to enable additional behavior like f string support.
There was a problem hiding this comment.
Replacing the enum since it's not extendable, in the current enum state other applications adding their own scanners can't add additional model formats or issue codes
CandiedCode
reviewed
May 23, 2024
Comment on lines
+9
to
+15
| class SkipCategories: | ||
| SCAN_NOT_SUPPORTED = Property("SCAN_NOT_SUPPORTED", 1) | ||
| BAD_ZIP = Property("BAD_ZIP", 2) | ||
| MODEL_CONFIG = Property("MODEL_CONFIG", 3) | ||
| H5_DATA = Property("H5_DATA", 4) | ||
| NOT_IMPLEMENTED = Property("NOT_IMPLEMENTED", 5) | ||
| MAGIC_NUMBER = Property("MAGIC_NUMBER", 6) |
There was a problem hiding this comment.
Would IntEnum be better here?
There was a problem hiding this comment.
same problem with not being extendable
iamfaisalkhan
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace SkipCategories, IssueCode, DefaultModelFormats enums with extendable classes
Renames DefaultModelFormats to SupportedModelFormats