Detect multiple Lambda layers #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modelscan/models/h5/scan.py
Outdated
| ] | ||
| if layer["class_name"] == "Lambda" | ||
| ] | ||
| model_config = json.loads(model_hdf5.attrs["model_config"]) |
There was a problem hiding this comment.
It might be a good idea here to handle JSONDecoderError in case parsing JSON fails for model_config.
There was a problem hiding this comment.
Yes, thank you, I have added try-except block to handle potential errors during JSON loading.
modelscan/models/h5/scan.py
Outdated
| layers = model_config["config"]["layers"] | ||
| lambda_layers = [] | ||
| for layer in layers: | ||
| if layer["class_name"] == "Lambda": |
There was a problem hiding this comment.
Should we also user layer.get(..) here as it is being used in the next line?
There was a problem hiding this comment.
Thank you for the review, I have updated it to layer.get(..)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, ModelScan can detect a Lambda layer in a Keras model. Though, ModelScan does not report if more than one Lambda layers are found in a given Keras model, i.e. one or more Lambda layers get reported as a single issue.
This PR adds functionality in ModelScan to report multiple Lambda layers if they exist in a Keras model.