Make blocklist use substrings instead of direct equality, other patches. #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpmorgan
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
__repr__for debugging purposes forOperatorIssueDetailsBlock
__import__for builtins, all imports should be done throughINST/GLOBAL/STACK_GLOBALanywaysFixed string (should be list) where
"operator": "attrgetter"in blocklistBlocked pty module (
pty.spawn('/bin/sh'))Blocked pickle module (
pickle.loads(bad_pickle))Revamp the filtering so that instead of a direct comparison between used attribute name and blocked attribute, we use substrings to successfully block
eval.__call__, for example, which was not previously blockedAdd malicious12 test case which uses
pickle.loads(malicious_pkl)Add malicious13 test case which uses
builtins-eval.__call__to bypass previous blocklist functionality