Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get scanners to load from settings and improve settings schema #77

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

swashko
Copy link
Collaborator

@swashko swashko commented Jan 11, 2024

Changes ModelScan initialization so it reads the scanners to load from which ones are enabled in the settings instead of having an additional argument. This allows for custom scanners to be used through the CLI

Also updates the settings schema for clarity so the unsafe_operators are a separate field from scanners

@swashko swashko requested a review from seanpmorgan January 11, 2024 01:35
@swashko swashko self-assigned this Jan 11, 2024
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@seanpmorgan seanpmorgan merged commit 3b20681 into main Jan 12, 2024
8 checks passed
@seanpmorgan seanpmorgan deleted the scanners-from-settings branch January 12, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants