Update Naming and Split SavedModelScan #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
swashko
commented
Jan 17, 2024
swashko
commented
- Updates naming of scanner classes to reflect what they're scanning for
- Splits SavedModelScan into SavedModelLambdaDetectScan and SavedModelTensorflowOpScan subclasses for the two different scans it was performing (lambda detection for keras files, ReadFile/WriteFile detection for tensorflow files)
- KerasLambdaDetectScan and H5LambdaDetectScan now inherit from SavedModelLambdaDetectScan
seanpmorgan
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
LGTM Thanks. I've checked off half of #80 . Going forward we'll want to catch missing or lesser versions in settings files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.