Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notebooks with JSON Reporting #92

Merged
merged 5 commits into from
Jan 26, 2024
Merged

Update notebooks with JSON Reporting #92

merged 5 commits into from
Jan 26, 2024

Conversation

mehrinkiani
Copy link
Member

This PR adds the JSON reporting format in notebooks.

By default, ModelScan reports scan results in console. In ModelScan v0.5, scan results can also be saved as a JSON report using:

modelscan -p path-to/file -r json -o file-name.json

@mehrinkiani mehrinkiani self-assigned this Jan 25, 2024
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM. Can you update the README.md as well to include the -r and -o parameter in the cli matrrix too

Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@seanpmorgan seanpmorgan merged commit 01d8cbd into main Jan 26, 2024
8 checks passed
@seanpmorgan seanpmorgan deleted the update-notebooks branch January 26, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants