Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip H5 files with no model_config #96

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Skip H5 files with no model_config #96

merged 3 commits into from
Feb 5, 2024

Conversation

swashko
Copy link
Collaborator

@swashko swashko commented Feb 1, 2024

Modelscan was failing on h5 files that have no model_config attribute
Adds a check for a model_config and skips the H5LambdaDetectScan scan if there isn't one

Closes #93

@swashko swashko self-assigned this Feb 1, 2024
@swashko swashko marked this pull request as draft February 1, 2024 21:34
@swashko swashko marked this pull request as ready for review February 1, 2024 23:22
Copy link
Member

@iamfaisalkhan iamfaisalkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@swashko swashko merged commit e3a3773 into main Feb 5, 2024
8 checks passed
@swashko swashko deleted the h5-no-config branch February 5, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

H5 file cannot be scanned
2 participants