-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions on using the BCR to the README.md #19967
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@binitshah Thank you for the pull request, but we won't be able to review it until you sign the CLA. You might also need to amend your Git commit to use the same email address that you use to sign the CLA. |
If your project is using Bazel, you can make your builds more reproducible by depending on protobuf through the Bazel Central Registry, instead of building it from source.
Hey Adam, I've made the changes. |
* \<messages\>.pb.cc/.h | ||
* Generated using `protoc`, downloaded from [Github Releases](https://github.com/protocolbuffers/protobuf/releases). | ||
* Check the runtime version of the compiler using `protoc --version`. It'll return something like "libprotoc 29.2". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this section is unnecessary, specifically for Bazel workflows (it may be useful for others)
* ``` | ||
bazel_dep(name = "protobuf", version = "29.2") | ||
``` | ||
* Note that the version matches `protoc`'s version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one too, if you're using a fully Bazel approach you don't have to worry about version mismatch
If your C++ project is using Bazel, you can make your builds more reproducible by depending on protobuf through the Bazel Central Registry, instead of building it from source.