Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug modal on Tx Queue tab when a transaction is executed #146

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

henrypalacios
Copy link
Collaborator

@henrypalacios henrypalacios commented Mar 1, 2024

Issue

When a transaction is executed an event is emitted that enables the Modal view that gives the options to stay or go to the history, the problem is that it cannot be closed until consulting the indexer.

  • Proposal:
    When the event is emitted, return the pending transaction only once so that it does not raise the modal again.

ER:
You should be able to close the modal or go to the history tab.

@henrypalacios henrypalacios self-assigned this Mar 1, 2024
Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ink-multisig-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 3:34pm
story-ink-multisig-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 3:34pm

@henrypalacios henrypalacios changed the title bug modal stayhere Fix bug modal stayhere or go to history Mar 1, 2024
@henrypalacios henrypalacios changed the title Fix bug modal stayhere or go to history Fix bug modal on Tx Queue tab when a transaction is executed Mar 1, 2024
@henrypalacios henrypalacios merged commit e331924 into develop Mar 4, 2024
4 checks passed
@henrypalacios henrypalacios deleted the bug-modal-stayhere branch March 4, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants