Feat/connector v1.3 rebased WIP #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...which also makes the visibility specifiers & fxn modifiers easier to see.
Now users can query prices for their (or others') contracts!
...to both `0.4.25` & `0.5` version of the API.
...and removes the now outdated `gasPriceBump` version
...and thus removes the now out-dated `gasPriceBump` nomenclature.
...and has to switch to lower level calls w/ a sprinkling of assembly to get at the return values in order to deal with overloaded interfaces. Pertinent issue here: ethereum/solidity#526 (comment)
...to get a neater separation of the queries from those with the dynamic arguments.
...since it's free w/r/t compile size if functions go unused.
... & also cleans up the natspec comments surrounding the various overload types.
... & also update the natspec comments to make the API easier to navigate.
reverting changes I requested for consistency with 0.5 and previous iterations
D-Nice
force-pushed
the
feat/connector-v1.3-rebased
branch
from
54a83cd to
623afc5
Compare
|
recent org rename broke the ci, and had to resync it |
Don't be daft. Completely fine by me. Plus if you drill into it it points us out as the author & the committer separately. Plus I'm still the one who'll get |
D-Nice
force-pushed
the
feat/connector-v1.3
branch
from
a8371e4 to
3d358e4
Compare
|
closing as rebase has been done on #88 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just draft to verify correct rebasing. Apologies to @gskapka on the dual authorship, can circumvent it by having you redo my steps, and it should only be your authorship in that case, which is more correct.