Upgrade to 1.8.0 prov release #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minxylynx
requested review from
a team,
mtps,
ChrisKenison and
EasyEtHP4
as code owners
minxylynx
force-pushed
the
crussell/299-1.8.0-upgrade
branch
7 times, most recently
from
d93fa49 to
8f2f88e
Compare
* Brought in the new proto jar, which replaces the in-service proto building * Dependency cleanup * Added attributes, UUID to NFT API * Fully supporting msg based fee breakdown * Updated Params API to include MsgFee params * Updates to event scraping, tied to increased Smart Contract usage * Added Msg-Based Fee API * Added procedure to update tx fees from a specific height * Rewrote mirgrations 1.49, 1.50 * Updated gas stat models to reflect proper terms * Updated API docs closes: #299
minxylynx
force-pushed
the
crussell/299-1.8.0-upgrade
branch
from
8f2f88e to
e9cae8d
Compare
ChrisKenison
reviewed
Mar 7, 2022
| fun getValidatorMarketRateAvg(address: String, txCount: Int) = | ||
| ValidatorMarketRateRecord.getValidatorRateForBlockCount(address, txCount) | ||
| .map { it.marketRate } | ||
| .let { list -> MarketRateAvg(list.size, list.minOrNull()!!, list.maxOrNull()!!, list.average()) } |
There was a problem hiding this comment.
This seems weird to call a method that can return null and then !! it
There was a problem hiding this comment.
The extension I would use is deprecated in favor of that one that is currently used
@Deprecated("Use minOrNull instead.", ReplaceWith("this.minOrNull()"))
@DeprecatedSinceKotlin(warningSince = "1.4", errorSince = "1.5")
public fun <T : Comparable<T>> Iterable<T>.min(): T? {
return minOrNull()
}
ChrisKenison
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #299
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes