Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait-RSJob - customizable progress bar #209

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jeffchulg
Copy link

Fixes # .

Changes proposed in this pull request:
Wait-RsJob:

  • Switch to boolean for parameter that shows progress bar
  • Enable dynamic title and message in displayed progress bar

How to test this code:

  • Run as usual

Has been tested on (remove any that don't apply):

  • Powershell 5 and Windows 10

@MVKozlov
Copy link
Contributor

MVKozlov commented Sep 1, 2020

Switch to boolean for parameter that shows progress bar

what is the reason for this replacement ?

@jeffchulg
Copy link
Author

@MVKozlov I think it's preferable when you have a config file in which you tell "show progress" or not... Otherwise, there is the need to create two different calls, just for that.

@MVKozlov
Copy link
Contributor

MVKozlov commented Sep 2, 2020

Did you know that -Parameter:value syntax acceptable for both switches and booleans ?
Seems not ;)
Its a common practice to use it for example for -Confirm:$confirm cases and for -ShowProgress too

@jeffchulg
Copy link
Author

No, I didn't know. So, Switch or boolean are very similar then

@MVKozlov
Copy link
Contributor

MVKozlov commented Sep 3, 2020

yes, but switch can be used as a boolean and does not require parameter. But boolean can not and require value.
It is a breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants