-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove interop genesis service from beacon node #14417
Open
prestonvanloon
wants to merge
15
commits into
develop
Choose a base branch
from
rm-interop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Specifically, remove the interop genesis service. Finding links to pebble: bazel query 'somepath(//cmd/beacon-chain, @com_github_cockroachdb_pebble//...)' --notool_deps
prestonvanloon
force-pushed
the
rm-interop
branch
from
September 27, 2024 18:03
24dac88
to
f9a9823
Compare
prestonvanloon
force-pushed
the
rm-interop
branch
from
November 20, 2024 13:30
4360340
to
0ceb69c
Compare
terencechain
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
The intention of this PR is to reduce unnecessary dependencies in the beacon node and reduce legacy tech debt. The features of
--interop-genesis-time
and--interop-num-validators
can be replaced by generating the beacon state with external tooling and using it within the beacon node via--genesis-state=/path/to/genesis.ssz
.Caution
The devnet instructions are mostly incomplete, but should not block this PR.
Running a devnet
Example workflow prior to this PR:
The new workflow is an additional step, but common practice with devnets.
Which issues(s) does this PR fix?
Other notes for review
Note: The interop functionality of the validator is unchanged for now. The flags
--interop-num-validators
and--interop-start-index
remain in the validator client until a follow up PR.Acknowledgements