-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execution API Electra: requests as a sidecar #14492
Merged
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
3172789
wip
james-prysm 806d783
Merge branch 'develop' into execution-request-sidecar-electra
james-prysm e5b8bd3
gaz
james-prysm 5976923
rename field
james-prysm 426f664
sammy review
james-prysm 3b0c6e2
updating execution api request and reverting response back
james-prysm c215ba9
fixing linting
james-prysm ed07b75
changelog
james-prysm 7517ac3
Merge branch 'develop' into execution-request-sidecar-electra
james-prysm 069f8c8
Merge branch 'develop' into execution-request-sidecar-electra
james-prysm 56dc32a
Merge branch 'develop' into execution-request-sidecar-electra
james-prysm e7dfa24
Merge branch 'develop' into execution-request-sidecar-electra
james-prysm e985dd8
Merge branch 'develop' into execution-request-sidecar-electra
james-prysm 015aeed
changelog
james-prysm 81e4648
Merge branch 'develop' into execution-request-sidecar-electra
james-prysm ef8281e
Merge branch 'develop' into execution-request-sidecar-electra
james-prysm 7767410
Merge branch 'develop' into execution-request-sidecar-electra
james-prysm 0e7a058
adding in serialization of requests
james-prysm 575b528
code cleanup
james-prysm f854fdf
adding some happy path tests and fixing mock
james-prysm 4a44864
mock still broken
james-prysm e533241
fixing linting
james-prysm 539a633
updating name on proto
james-prysm 2cec3a4
missed naming
james-prysm 12f0a06
placeholder fix for TestClient_HTTP
james-prysm ff3170a
removing duplicate change log
james-prysm 9dae721
adding in test for get payloadv4 as well as some tests
james-prysm 8362871
added tests for execution client testing, fixed encode type
james-prysm 43e01c4
adding comment for placeholder test
james-prysm f7ef1f3
fixing test and addressing feedback
james-prysm b41b707
Merge branch 'develop' into execution-request-sidecar-electra
james-prysm 7438ba2
Merge branch 'develop' into execution-request-sidecar-electra
james-prysm 040e48c
Merge branch 'develop' into execution-request-sidecar-electra
james-prysm c24825a
Merge branch 'develop' into execution-request-sidecar-electra
james-prysm 9cc52a3
feedback
james-prysm ad56480
flipping the test names, was used in reverse
james-prysm 5f95c3d
feedback from kasey
james-prysm 8ee48ca
Merge branch 'develop' into execution-request-sidecar-electra
james-prysm 6c8baf5
Merge branch 'develop' into execution-request-sidecar-electra
james-prysm 0580bb5
reverting switch back to if statements to fix bug
james-prysm bea42f4
Merge branch 'develop' into execution-request-sidecar-electra
james-prysm 2ffb01b
lint
james-prysm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels prone to bugs and hard to test against . Checking payload's version may be better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah , the caller checks the version on the block, but the payload doesn't include the version , I can pass the block version into this function if that makes it safer