validator REST: attestation v2 #14633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
commented
Nov 7, 2024
james-prysm
commented
Nov 8, 2024
james-prysm
commented
Nov 8, 2024
| return nil, errors.Wrap(err, "failed to get attestation data") | ||
| } | ||
|
|
||
| signature, err := hexutil.Decode(jsonAttestation.Signature) |
There was a problem hiding this comment.
should we be checking for lengths?
There was a problem hiding this comment.
maybe we can add this in a future PR, but I would not do it here
james-prysm
commented
Nov 8, 2024
saolyn
reviewed
Nov 12, 2024
rkapka
reviewed
Nov 19, 2024
james-prysm
commented
Nov 19, 2024
|
|
||
| aggregatedAttestation, err := convertAttestationToProto(attData) | ||
| var aggregateAttestationResponse structs.AggregateAttestationResponse | ||
| err := c.jsonRestHandler.Get(ctx, endpoint, &aggregateAttestationResponse) |
There was a problem hiding this comment.
I think i need to add a header to this too for eth consensus version https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Validator/getAggregatedAttestationV2
rkapka
requested changes
Nov 20, 2024
Comment on lines
106
to
112
| attElectra, ok := attestation.(*ethpb.AttestationElectra) | ||
| if !ok { | ||
| return errors.New("attestation is not electra") | ||
| } | ||
| if len(attElectra.CommitteeBits) == 0 { | ||
| return errors.New("attestation committee bits can't be nil") | ||
| } |
There was a problem hiding this comment.
You can just call attestation.CommitteeBitsVal()
rkapka
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
added the use of the following endpoints for validator rest mode to support the Electra hardfork
/eth/v2/beacon/pool/attestationsPOST/eth/v2/validator/aggregate_and_proofsPOST/eth/v2/validator/aggregate_attestationGETTested via e2e :
bazel test //testing/endtoend:go_minimal_scenario_test --test_output=streamed --test_timeout=10000 --test_filter=TestEndToEnd_MinimalConfig_ValidatorRESTApi --flaky_test_attempts=1Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements