Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix packer invocation on cygwin #38

Merged
merged 1 commit into from
Nov 23, 2023
Merged

fix packer invocation on cygwin #38

merged 1 commit into from
Nov 23, 2023

Conversation

secretagentmoof
Copy link

cygwin uses .dll, not .so, for its libraries

@AKuHAK
Copy link
Contributor

AKuHAK commented Nov 23, 2023 •
edited
Loading

Don't understand the purpose of this change. The whole Windows family uses dll, not only Cygwin.

@secretagentmoof
Copy link
Author

secretagentmoof commented Nov 23, 2023 •
edited
Loading

For whatever reason, cygwin does not define _WIN32; the suffix defaults to .so, and the packer tries to load ./lzma-packer.so (and fails). cygwin does expose __CYGWIN__, however.

@uyjulian uyjulian merged commit 26bfd0f into ps2dev:master Nov 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@secretagentmoof @AKuHAK @uyjulian @dorkulon