parse magic-wormhole-protocols spec URIs #45
Conversation
| @@ -924,24 +924,29 @@ type parsedCode struct { | |||
| } | |||
|
|
|||
| func parseCodeURI(codeStr string) (*parsedCode, error) { | |||
| if !strings.HasPrefix(codeStr, "wormhole:") { | |||
There was a problem hiding this comment.
I want to continue to support this protocol so to not break existing clients.
|
It looks like there is quite a lot wrong with this PR. Please add a unit test for this function that covers the existing and new functionality. |
Yes, sorry, I tend to push stuff as I have it. I'll take it out of Draft when I believe a review or further action is in order. (If any "actual Go programmers" watching feel motivated, I'm happy to take help). I thought I had a build from Android Studio but it must have built something else. |
|
The function is very self contained so you should be able to test it in a stand alone project (or on the go playground). That will probably be easier than setting up a build environment for this project. |
caveat: I have not built Go before, nor a phone-project. Hoping this runs CI :)