Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getting_started.md #4518

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Update getting_started.md #4518

merged 2 commits into from
Nov 26, 2024

Conversation

sorxill
Copy link
Contributor

@sorxill sorxill commented Nov 25, 2024

Description

Updated the python version in the documentation in accordance with README.md a file, so as not to confuse users.

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

Update necessary python version to run black in docs.
@sorxill sorxill changed the base branch from stable to main November 25, 2024 22:22
@JelleZijlstra JelleZijlstra added the skip news Pull requests that don't need a changelog entry. label Nov 26, 2024
@JelleZijlstra JelleZijlstra merged commit 17efac4 into psf:main Nov 26, 2024
16 of 17 checks passed
@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Nov 26, 2024

@JelleZijlstra what did you merge here? I don't see any diff

@JelleZijlstra
Copy link
Collaborator

Uh good point. At some point the PR changed something from 3.8 to 3.9 but that appears to have been merged away.

@sorxill
Copy link
Contributor Author

sorxill commented Nov 26, 2024

@JelleZijlstra Hm. I changed the required python version in docs site. Why is this not in the final version? Is this my mistake?

@JelleZijlstra
Copy link
Collaborator

I suspect (but haven't checked) this is already fixed in the main branch. Your initial PR was against the stable version, which is a bit old by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants