Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for negative states + Add tests #175

Merged
merged 4 commits into from
Sep 13, 2023

Conversation

pedromxavier
Copy link
Contributor

This PR aims to address #157 and supersede #158.

@pedromxavier pedromxavier added the bug Something isn't working label Aug 9, 2023
@pedromxavier pedromxavier self-assigned this Aug 9, 2023
src/OpenBinary/reader.jl Show resolved Hide resolved
src/OpenBinary/reader.jl Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2023

Codecov Report

Patch coverage: 68.75% and project coverage change: -0.03% ⚠️

Comparison is base (a990a4d) 79.85% compared to head (c321643) 79.82%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   79.85%   79.82%   -0.03%     
==========================================
  Files          21       21              
  Lines        2810     2816       +6     
==========================================
+ Hits         2244     2248       +4     
- Misses        566      568       +2     
Files Changed Coverage Δ
src/OpenStudy/duration.jl 95.96% <ø> (ø)
src/reader_mapper.jl 85.96% <ø> (ø)
src/tables/interface.jl 77.08% <50.00%> (+3.12%) ⬆️
src/OpenBinary/writer.jl 80.95% <61.90%> (-0.47%) ⬇️
src/OpenBinary/reader.jl 79.34% <72.72%> (-0.99%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raphasampaio raphasampaio merged commit 55a9ed8 into master Sep 13, 2023
@raphasampaio raphasampaio deleted the px/negative-states-alt branch September 13, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants