Merge pull request #1574 from psu-stewardship/i#1520a-email-stats

Verify that emails are sent for monthly stats

app/jobs/user_stats_notification_job.rb

@@ -6,7 +6,7 @@ def perform(id:, start_date:, end_date:)
     return unless PsuDir::LdapUser.check_ldap_exist!(user.login)
 
     UserMailer.user_stats_email(
-      user_email: user.email,
+      user: user,
       start_date: start_date,
       end_date: end_date
     ).deliver_now

config/sample/application.yml

@@ -9,7 +9,7 @@ development:
   service_instance: "localhost"
   virtual_host: "http://localhost:3000/"
   stats_email: "ScholarSphere Stats <[email protected]>"
-  no_reply_email: "no_repy@scholarsphere.psu.edu"
+  no_reply_email: "no_reply@scholarsphere.psu.edu"
   google_analytics_id: "test-id"
   read_only: "false"
   EZID_USER: 'ezid_user'
@@ -30,7 +30,7 @@ test:
   service_instance: "example-test"
   virtual_host: "http://test.com/"
   stats_email: "Test email"
-  no_reply_email: "no_repy@scholarsphere.psu.edu"
+  no_reply_email: "no_reply@scholarsphere.psu.edu"
   google_analytics_id: "test-id"
   read_only: "false"
   RECAPTCHA_SITE_KEY: 'site-key'
@@ -48,7 +48,7 @@ production:
   service_instance: "example-prod"
   virtual_host: "http://test.com/"
   stats_email: "Test email"
-  no_reply_email: "no_repy@scholarsphere.psu.edu"
+  no_reply_email: "no_reply@scholarsphere.psu.edu"
   google_analytics_id: "test-id"
   derivatives_path: "path"
   read_only: "false"

config/travis/application_test.yml

@@ -9,7 +9,7 @@ development:
   service_instance: "localhost"
   virtual_host: "http://localhost:3000/"
   stats_email: "ScholarSphere Stats <[email protected]>"
-  no_reply_email: "no_repy@scholarsphere.psu.edu"
+  no_reply_email: "no_reply@scholarsphere.psu.edu"
   google_analytics_id: "test-id"
   read_only: "false"
   EZID_USER: 'ezid_user'
@@ -30,7 +30,7 @@ test:
   service_instance: "example-test"
   virtual_host: "http://test.com/"
   stats_email: "Test email"
-  no_reply_email: "no_repy@scholarsphere.psu.edu"
+  no_reply_email: "no_reply@scholarsphere.psu.edu"
   google_analytics_id: "test-id"
   read_only: "false"
   RECAPTCHA_SITE_KEY: 'site-key'
@@ -48,7 +48,7 @@ production:
   service_instance: "example-prod"
   virtual_host: "http://test.com/"
   stats_email: "Test email"
-  no_reply_email: "no_repy@scholarsphere.psu.edu"
+  no_reply_email: "no_reply@scholarsphere.psu.edu"
   google_analytics_id: "test-id"
   derivatives_path: "path"
   read_only: "false"

lib/tasks/scholarsphere/stats.rake

@@ -19,7 +19,7 @@ namespace :scholarsphere do
       start_date = Date.today.last_month.beginning_of_month
       end_date = Date.today.last_month.end_of_month
       UserStat.where(date: start_date..end_date).map(&:user_id).uniq.map do |id|
-        UserStatsNotificationJob.perform_later(id: id, start_date: start_date, end_date: end_date)
+        UserStatsNotificationJob.perform_later(id: id, start_date: start_date.to_s, end_date: end_date.to_s)
       end
     end
   end

spec/jobs/user_stats_notification_job_spec.rb

@@ -16,7 +16,7 @@
 
     it 'sends the email to the user' do
       expect(UserMailer).to receive(:user_stats_email)
-        .with(user_email: user.email, start_date: start_date, end_date: end_date)
+        .with(user: user, start_date: start_date, end_date: end_date)
         .and_return(mock_mailer)
       expect(mock_mailer).to receive(:deliver_now)
       described_class.perform_now(id: user.id, start_date: start_date, end_date: end_date)

spec/rake/scholarsphere/stats_spec.rb

@@ -17,15 +17,19 @@
     end
 
     context 'when a user has stats' do
-      let(:user) { create(:user) }
+      let(:user) { create(:user, email: '[email protected]') }
+      let(:message) { ActionMailer::Base.deliveries.first }
 
       before do
+        allow(PsuDir::LdapUser).to receive(:check_ldap_exist!).with(user.login).and_return(true)
         UserStat.create(user_id: user.id, date: (Date.today.last_month.beginning_of_month + 10), file_downloads: 5)
       end
 
       it 'sends an email to the user' do
-        expect(UserStatsNotificationJob).to receive(:perform_later)
         run_task('scholarsphere:stats:notify')
+        expect(message.to).to contain_exactly('[email protected]')
+        expect(message.from).to contain_exactly(ENV['no_reply_email'])
+        expect(message.subject).to eq('ScholarSphere - Reporting Monthly Downloads and Views')
       end
     end
   end