Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eslint #6353

Merged
merged 11 commits into from
Sep 15, 2024
Merged

Upgrade eslint #6353

merged 11 commits into from
Sep 15, 2024

Conversation

adikari
Copy link
Contributor

@adikari adikari commented Aug 28, 2024

This PR contains:

Upgrade eslint to latest version 9.9.1 and other eslint related packages

Describe the problem you have without this PR

upgrading eslint as per the linked issue #6350

@adikari
Copy link
Contributor Author

adikari commented Aug 28, 2024

@pubkey I will appreciate if you will approve the workflow trigger.

@adikari
Copy link
Contributor Author

adikari commented Aug 28, 2024

@pubkey need another approval. some checks failed in last push. hopefully its fixed now.

@adikari
Copy link
Contributor Author

adikari commented Aug 28, 2024

I have updated the eslint config so you can run it on the whole project. Previously it was only running on js and ts files.

@adikari
Copy link
Contributor Author

adikari commented Aug 30, 2024

@pubkey hopefully the last approval for checks. I will also appreciate if you can review the PR.

@adikari
Copy link
Contributor Author

adikari commented Sep 1, 2024

@pubkey can you pls re-run the checks. It failed coz of the test cleanup. I don't think it has anything to do with my changes.

@pubkey
Copy link
Owner

pubkey commented Sep 3, 2024

Yes. Your changes look good. Lets run the ci once more.

@adikari
Copy link
Contributor Author

adikari commented Sep 3, 2024

looks like all checks passed. However there was some merge conflict after the master branch was updated. I have fixed it now.

@adikari
Copy link
Contributor Author

adikari commented Sep 4, 2024

@pubkey can we please merge this. There are constant merge conflicts with master branch.

@adikari
Copy link
Contributor Author

adikari commented Sep 10, 2024

@pubkey I know you have been busy with v15 release. can you please look into this when ready.

@pubkey
Copy link
Owner

pubkey commented Sep 10, 2024

Sorry for the late answer. Will have a look at this today. You do not have to update incomong merge conflicts.

@pubkey
Copy link
Owner

pubkey commented Sep 11, 2024

Hi @adikari
This is missing the eslint versions from the other examples: https://github.com/pubkey/rxdb/pull/6115/files

I have a question: What is the reason for removing the eslintignore file, do we no longer need that? Will this not slow down the linting because now everything is linted even generated code?

@adikari
Copy link
Contributor Author

adikari commented Sep 11, 2024

@pubkey I will take a look a bit later on. Don't need the ignore file anymore as the ignores are part of the eslint config. I can ignore the generated files if you want but the performance is not a concern as it runs fairly quickly.

When I fix the current issue with the build you take a look and let me know if the performance is something that bothers you.


export default [
{
ignores: [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pubkey ignores are here

@adikari
Copy link
Contributor Author

adikari commented Sep 12, 2024

@pubkey ready to go

@adikari
Copy link
Contributor Author

adikari commented Sep 13, 2024

@pubkey looks all good. lets merge this pls

@pubkey pubkey merged commit 97b7d11 into pubkey:master Sep 15, 2024
21 checks passed
@adikari adikari deleted the upgrade-eslint branch September 16, 2024 11:39
@adikari
Copy link
Contributor Author

adikari commented Sep 16, 2024

@pubkey can you please give me access to premium for completing the task. I want to try it out in one of my projects.

@pubkey
Copy link
Owner

pubkey commented Sep 16, 2024

@adikari can you send me your address via email so I can send you the license for the free premium access? Email is [email protected] or you can write me at the RxDB discord.

@adikari
Copy link
Contributor Author

adikari commented Sep 16, 2024

@adikari can you send me your address via email so I can send you the license for the free premium access? Email is [email protected] or you can write me at the RxDB discord.

Just sent you an email. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants