-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade eslint #6353
Upgrade eslint #6353
Conversation
@pubkey I will appreciate if you will approve the workflow trigger. |
0104001
to
93f98b8
Compare
@pubkey need another approval. some checks failed in last push. hopefully its fixed now. |
I have updated the eslint config so you can run it on the whole project. Previously it was only running on |
@pubkey hopefully the last approval for checks. I will also appreciate if you can review the PR. |
@pubkey can you pls re-run the checks. It failed coz of the test cleanup. I don't think it has anything to do with my changes. |
Yes. Your changes look good. Lets run the ci once more. |
looks like all checks passed. However there was some merge conflict after the master branch was updated. I have fixed it now. |
@pubkey can we please merge this. There are constant merge conflicts with master branch. |
@pubkey I know you have been busy with v15 release. can you please look into this when ready. |
Sorry for the late answer. Will have a look at this today. You do not have to update incomong merge conflicts. |
Hi @adikari I have a question: What is the reason for removing the eslintignore file, do we no longer need that? Will this not slow down the linting because now everything is linted even generated code? |
@pubkey I will take a look a bit later on. Don't need the ignore file anymore as the ignores are part of the eslint config. I can ignore the generated files if you want but the performance is not a concern as it runs fairly quickly. When I fix the current issue with the build you take a look and let me know if the performance is something that bothers you. |
|
||
export default [ | ||
{ | ||
ignores: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pubkey ignores are here
89cf585
to
5956d19
Compare
@pubkey ready to go |
@pubkey looks all good. lets merge this pls |
@pubkey can you please give me access to premium for completing the task. I want to try it out in one of my projects. |
@adikari can you send me your address via email so I can send you the license for the free premium access? Email is [email protected] or you can write me at the RxDB discord. |
Just sent you an email. Cheers |
This PR contains:
Upgrade eslint to latest version 9.9.1 and other eslint related packages
Describe the problem you have without this PR
upgrading eslint as per the linked issue #6350