When the pulled documents in the replication do not match the schema, do not update the checkpoint.

docs-src/docs/releases/16.0.0.md

@@ -77,6 +77,7 @@ I completely rewrote them and improved performance especially on initial load wh
 - Throw error when dexie.js RxStorage is used with optional index fields [#6643](https://github.com/pubkey/rxdb/pull/6643#issuecomment-2505310082).
 - Fix IndexedDB bug: Some people had problems with the IndexedDB RxStorage that opened up collections very slowly. If you had this problem, please try out this new version.
 - Add check to ensure remote instances are build with the same RxDB version. This is to ensure if you update RxDB and forget to rebuild your workers, it will throw instead of causing strange problems.
+- When the pulled documents in the replication do not match the schema, do not update the checkpoint.
 
 ## Other
 

src/replication-protocol/downstream.ts

@@ -14,7 +14,8 @@ import type {
     ById,
     WithDeleted,
     DocumentsWithCheckpoint,
-    WithDeletedAndAttachments
+    WithDeletedAndAttachments,
+    RxError
 } from '../types/index.d.ts';
 import {
     appendToArray,
@@ -472,6 +473,7 @@ export async function startReplicationDownstream<RxDocType, CheckpointType = any
                             state.events.processed.down.next(writeRowsToForkById[docId]);
                             useMetaWriteRows.push(writeRowsToMeta[docId]);
                         });
+                        let mustThrow: RxError | undefined;
                         forkWriteResult.error.forEach(error => {
                             /**
                              * We do not have to care about downstream conflict errors here
@@ -481,10 +483,16 @@ export async function startReplicationDownstream<RxDocType, CheckpointType = any
                                 return;
                             }
                             // other non-conflict errors must be handled
-                            state.events.error.next(newRxError('RC_PULL', {
+                            const throwMe = newRxError('RC_PULL', {
                                 writeError: error
-                            }));
+                            });
+                            state.events.error.next(throwMe);
+                            mustThrow =
+                                mustThrow = throwMe;
                         });
+                        if (mustThrow) {
+                            throw mustThrow;
+                        }
                     });
                 }
             }).then(() => {

test/unit/replication.test.ts

@@ -344,6 +344,14 @@ describe('replication.test.ts', () => {
             const amount = 5;
             const { localCollection, remoteCollection } = await getTestCollections({ local: 0, remote: amount });
 
+            // // add onee that still matches the schema
+            // await remoteCollection.insert({
+            //     id: 'matches-schema',
+            //     name: 'foobar',
+            //     updatedAt: 1001,
+            //     age: 0
+            // });
+
             /**
              * Use collection with different schema
              * to provoke validation errors.
@@ -359,7 +367,7 @@ describe('replication.test.ts', () => {
             const replicationState = replicateRxCollection({
                 collection: otherSchemaCollection as any,
                 replicationIdentifier: REPLICATION_IDENTIFIER_TEST,
-                live: false,
+                live: true,
                 pull: {
                     handler: getPullHandler(remoteCollection)
                 },
@@ -378,9 +386,16 @@ describe('replication.test.ts', () => {
             assert.strictEqual(docsLocal.length, 0);
 
 
-            assert.strictEqual(errors.length, amount);
+            // assert.strictEqual(errors.length, amount);
             assert.ok(JSON.stringify(errors[0].parameters).includes('maximum'));
 
+            const pullCheckpointAfter = await getLastCheckpointDoc(
+                ensureNotFalsy(replicationState.internalReplicationState),
+                'down'
+            );
+
+            // when all pulls failed, it should not have the checkpoint updated
+            assert.ok(!pullCheckpointAfter);
 
             localCollection.database.close();
             remoteCollection.database.close();