Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cdn77-storage.com and rsc.contentproxy9.cz #1882

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

007hacky007
Copy link
Contributor

@007hacky007 007hacky007 commented Oct 25, 2023

Added cdn77-storage.com for our object storage service and rsc.contentproxy9.cz used by some of our CDN customers.

Public Suffix List (PSL) Pull Request (PR) Template

Each PSL PR needs to have a description, rationale, indication of DNS validation and syntax checking, as well as a number of acknowledgements from the submitter. This template must be included with each PR, and the submitting party MUST provide responses to all of the elements in order to be considered.

Checklist of required steps

  • Description of Organization

  • Robust Reason for PSL Inclusion

  • DNS verification via dig

  • Run Syntax Checker (make test)

  • Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _PSL txt record in place in the respective zone(s) in the affected section

Submitter affirms the following:

  • We are listing any third-party limits that we seek to work around in our rationale such as those between IOS 14.5+ and Facebook (see Issue #1245 as a well-documented example)
  • This request was not submitted with the objective of working around other third-party limits
  • The Guidelines were carefully read and understood, and this request conforms
  • The submission follows the guidelines on formatting and sorting

For Private section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.

To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.

PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.

(Link: about propagation/expectations)

  • Yes, I understand. I could break my organization's website cookies etc. and the rollback timing, etc is acceptable. Proceed.

Description of Organization

Organization Website: https://www.cdn77.com

CDN77.com is a Content Delivery Network which provides services
on customer's domains OR on selected (sub)domains listed in the PSL.

CDN77 also offers object storage which is also available through chosen sub-domain on the main domain
listen in the PSL.

Reason for PSL Inclusion

I'm the CTO of the CDN77 company. We already have our main domains added in the PSL
from the past, however we launched new service (object storage) which we dedicated new domain for. Our clients use this domain to access our new object storage service. We also have one CDN domain which has been in use for few years now, yet it was not added to the PSL yet.

Number of users this request is being made to serve:

  • cdn77-storage.com: thousands and growing
  • rsc.contentproxy9.cz: tens to lower hundrends approx.

DNS Verification via dig

% dig +short TXT _psl.cdn77-storage.com
"https://github.com/publicsuffix/list/pull/1882"
% dig +short TXT _psl.rsc.contentproxy9.cz
"https://github.com/publicsuffix/list/pull/1882"

Results of Syntax Checker (make test)

$ make test
cd linter;                                \
	  ./pslint_selftest.sh;                     \
	  ./pslint.py ../public_suffix_list.dat;
-n test_NFKC:
OK
-n test_allowedchars:
OK
-n test_dots:
OK
-n test_duplicate:
OK
-n test_exception:
OK
-n test_punycode:
OK
-n test_section1:
OK
-n test_section2:
OK
-n test_section3:
OK
-n test_section4:
OK
-n test_spaces:
OK
-n test_wildcard:
OK
14909: warning: Leading/Trailing whitespace: '// Former AFNIC's SLDs '
test -d libpsl || git clone --depth=1 https://github.com/rockdaboot/libpsl;   \
	  cd libpsl;                                                                    \
	  git pull;                                                                     \
	  echo "EXTRA_DIST =" >  gtk-doc.make;                                          \
	  echo "CLEANFILES =" >> gtk-doc.make;                                          \
	  autoreconf --install --force --symlink;
Already up to date.
autopoint: using AM_GNU_GETTEXT_REQUIRE_VERSION instead of AM_GNU_GETTEXT_VERSION
glibtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'build-aux'.
glibtoolize: linking file 'build-aux/ltmain.sh'
glibtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
glibtoolize: linking file 'm4/libtool.m4'
glibtoolize: linking file 'm4/ltoptions.m4'
glibtoolize: linking file 'm4/ltsugar.m4'
glibtoolize: linking file 'm4/ltversion.m4'
glibtoolize: linking file 'm4/lt~obsolete.m4'
configure.ac:1: warning: file `version.txt' included several times
configure.ac:4: warning: file `version.txt' included several times
aclocal.m4:765: AM_INIT_AUTOMAKE is expanded from...
configure.ac:4: the top level
configure.ac:383: warning: file `version.txt' included several times
configure.ac:10: installing 'build-aux/compile'
configure.ac:4: installing 'build-aux/missing'
fuzz/Makefile.am: installing 'build-aux/depcomp'
cd libpsl && ./configure -q -C --enable-runtime=libicu --enable-builtin=libicu --with-psl-file=/Users/honza/Documents/Go/list/public_suffix_list.dat --with-psl-testfile=/Users/honza/Documents/Go/list/tests/tests.txt && make -s clean && make -s check -j4
ld: warning: -single_module is obsolete
configure: WARNING: --enable-builtin=libicu is deprecated, use --enable-builtin (enabled by default)
config.status: creating po/POTFILES
config.status: creating po/Makefile
Making clean in po
Making clean in include
Making clean in src
rm -f ./so_locations
Making clean in tools
 rm -f psl
Making clean in fuzz
 rm -f libpsl_icu_fuzzer libpsl_icu_load_fuzzer libpsl_icu_load_dafsa_fuzzer
Making clean in tests
 rm -f test-is-public test-is-public-all test-is-cookie-domain-acceptable test-is-public-builtin test-registrable-domain
Making clean in msvc
Making check in po
Making check in include
Making check in src
  CC       libpsl_la-psl.lo
  CC       libpsl_la-lookup_string_in_fixed_set.lo
  CCLD     libpsl.la
Making check in tools
  CC       psl.o
  CCLD     psl
Making check in fuzz
  CC       libpsl_fuzzer.o
  CC       main.o
  CC       libpsl_load_fuzzer.o
  CC       libpsl_load_dafsa_fuzzer.o
  CCLD     libpsl_icu_fuzzer
  CCLD     libpsl_icu_load_fuzzer
  CCLD     libpsl_icu_load_dafsa_fuzzer
PASS: libpsl_icu_load_dafsa_fuzzer
PASS: libpsl_icu_fuzzer
PASS: libpsl_icu_load_fuzzer
============================================================================
Testsuite summary for libpsl 0.21.2
============================================================================
# TOTAL: 3
# PASS:  3
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
Making check in tests
  CC       test-is-public.o
  CC       test-is-public-all.o
  CC       test-is-cookie-domain-acceptable.o
  CC       test-is-public-builtin.o
  CC       test-registrable-domain.o
  CCLD     test-is-cookie-domain-acceptable
  CCLD     test-is-public-builtin
  CCLD     test-is-public
  CCLD     test-is-public-all
libtool: warning: '-no-install' is ignored for aarch64-apple-darwin22.6.0
libtool: warning: '-no-install' is ignored for aarch64-apple-darwin22.6.0
libtool: warning: '-no-install' is ignored for aarch64-apple-darwin22.6.0
libtool: warning: assuming '-no-fast-install' instead
libtool: warning: assuming '-no-fast-install' instead
libtool: warning: '-no-install' is ignored for aarch64-apple-darwin22.6.0
libtool: warning: assuming '-no-fast-install' instead
libtool: warning: assuming '-no-fast-install' instead
  CCLD     test-registrable-domain
libtool: warning: '-no-install' is ignored for aarch64-apple-darwin22.6.0
libtool: warning: assuming '-no-fast-install' instead
PASS: test-is-public
PASS: test-is-public-all
PASS: test-is-cookie-domain-acceptable
PASS: test-is-public-builtin
PASS: test-registrable-domain
============================================================================
Testsuite summary for libpsl 0.21.2
============================================================================
# TOTAL: 5
# PASS:  5
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
Making check in msvc

@simon-friedberger simon-friedberger added the ✔️DNS _psl Validated RFC 8553 Entries were present, matching PR# label Nov 6, 2023
@simon-friedberger
Copy link
Contributor

@dnsguru The guidelines don't really specify how exactly to sort entries of different length. According to the ruby script longer entries come first. Is that correct?

@simon-friedberger simon-friedberger added the NOT IOS FB Submitter attests PR is not #1245 related label Nov 6, 2023
Copy link
Contributor

@simon-friedberger simon-friedberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless @dnsguru thinks the sorting should actually not match ruby, LGTM.

@007hacky007
Copy link
Contributor Author

Bump. Can we push this forward, please? Anything missing from my side in the PR?

@simon-friedberger
Copy link
Contributor

simon-friedberger commented Feb 1, 2024

  • Expiration
    • dn77-storage.com expires 2033-12-13
    • contentproxy9.cz expires 2032-01-02
  • DNS _psl entries
  • Tests pass
  • Sorting according to guidelines
  • Reasoning/Organization description

@simon-friedberger simon-friedberger added ❌FAIL - DOMAIN NOT 2Y+ *ALL* names in PRIVATE section MUST hold terms of 2 years or more registration from PR date #1109 r=simon-friedberger Marked as approved and ready to merge by @simon-friedberger labels Feb 1, 2024
@007hacky007
Copy link
Contributor Author

Resolved

$ whois cdn77-storage.com | grep Expiry
   Registry Expiry Date: 2033-12-13T14:17:38Z

Apologies for the mistake.

@simon-friedberger simon-friedberger removed the ❌FAIL - DOMAIN NOT 2Y+ *ALL* names in PRIVATE section MUST hold terms of 2 years or more registration from PR date #1109 label Feb 1, 2024
@dnsguru dnsguru self-assigned this Feb 2, 2024
@simon-friedberger simon-friedberger merged commit 1d508aa into publicsuffix:master Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✔️DNS _psl Validated RFC 8553 Entries were present, matching PR# NOT IOS FB Submitter attests PR is not #1245 related r=simon-friedberger Marked as approved and ready to merge by @simon-friedberger
Projects
Status: Done or Won't
Development

Successfully merging this pull request may close these issues.

3 participants