Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix Alphabetizing for the ICANN section #2287

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: Fix Alphabetizing for the ICANN section #2287

wants to merge 2 commits into from
+523 −523

Conversation

groundcat
Copy link
Contributor

This PR is to address #2255

No entry has been modified, which can be verified with

diff <(sort public_suffix_list.dat) <(sort public_suffix_list_sorted.dat)

@wdhdev
Copy link
Contributor

wdhdev commented Nov 23, 2024

Are you able to share the script you used to sort it?

@groundcat
Copy link
Contributor Author

Script used:
https://gist.github.com/groundcat/6d81a42e009468c24a80d1c57a7211a8

@simon-friedberger
Copy link
Contributor

We should probably make sure that psltool also checks this now so it doesn't regress again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@groundcat @wdhdev @simon-friedberger