Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap v4 #32

Open
3 of 35 tasks
rajasegar opened this issue Dec 3, 2020 · 3 comments
Open
3 of 35 tasks

Bootstrap v4 #32

rajasegar opened this issue Dec 3, 2020 · 3 comments
Assignees

Comments

@rajasegar
Copy link
Collaborator

rajasegar commented Dec 3, 2020

This is a tracking issue for Bootstrap v4 upgrade for this lib

Components

  • Alerts
  • Badge
  • Breadcrumb
  • Buttons
  • Button group
  • Card
  • Carousel
  • Collapse
  • Dropdowns
  • Forms
  • Input group
  • Jumbotron
  • List group
  • Media object
  • Modal
  • Navs
  • Navbar
  • Pagination
  • Popovers
  • Progress
  • Scrollspy
  • Spinners
  • Toasts
  • Tooltips

Layouts

  • Album
  • Pricing
  • Checkout
  • Product
  • Cover
  • Carousel
  • Blog
  • Dashboard
  • Sign-in
  • Sticky footer
  • Sticky footer navbar
@rajasegar rajasegar self-assigned this Dec 3, 2020
@rajasegar rajasegar pinned this issue Dec 3, 2020
@ksaadDE
Copy link

ksaadDE commented Jan 2, 2021

Take a look at my repo https://github.com/ksaadDE/PUG-Bootstrap.git

I fixed the Topbar (with a few hacks, needs adaption) I changed your coding style as you can see in the usage example for the TopBar below:

`if locals.title
    +navbar(title, "dropdown_menu", "")
        +nav_item("/","t14l")
        +nav_item("/uploadfile","t21l", "t")
        
        +nav_dropdown("", "T23")
            +nav_dropdown_item("test", "Test23")
            +nav_dropdown_item("test2", "Test22")
            +nav_divider()
            +nav_dropdown_item("test2", "Test22")
            
        if session.user != undefined
            +nav_item("/user/dashboard", translations.navbar_loggedin_as + " " + session.user.name, translations.navbar_loggedin_as + " " + session.user.name)
        else
            +nav_item("/login", translations.navbar_login_text)
else
    +navbar("test", "dropdown_menu")
        +nav_item("/","t1l") Test
        +nav_item("/","t2l") Test2
`

navbar is defined by mixin navbar(name, id, style, href)
and
navitem is defined by mixin nav_item(href, label, style, active)

It's still in the navbar pug

Also a few things already working out of the box, which don't needs any fixing.

Buttons are still working I guess.

@rajasegar
Copy link
Collaborator Author

Looks good to me, if you are ready you can raise a PR against the b4 branch, I will take a look

@ksaadDE
Copy link

ksaadDE commented Jan 17, 2021

Looks good to me, if you are ready you can raise a PR against the b4 branch, I will take a look

Hey, currently my time is limited to work on it. You're free to copy what you need. If you want to use it. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants