More instructions for use are added #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
=======================================
Coverage 99.89% 99.89%
=======================================
Files 51 51
Lines 942 942
=======================================
Hits 941 941
Misses 1 1Continue to review full report at Codecov.
|
adrienverge
reviewed
Oct 24, 2019
README.md
Outdated
| ```json | ||
| { | ||
| "scripts": { | ||
| "lint:pug": "glob-exec \"./src/**/*.pug\" -- \"pug-lint {{files.join(' ')}}\"" |
There was a problem hiding this comment.
Is the extra dependency glob-exec really needed? Could you achieve the same, but simpler, with standard xargs?
Even better, just pug-lint $(git ls-files '*.pug')?
More generally, I'm not sure such instructions add real value to the README: they're really generic.
There was a problem hiding this comment.
Thanks for suggestion. I change script to git ls-files 'src/**/*.pug' | xargs pug-lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add instructions for integrate in npm scripts and git hooks with lint-staged