-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump electron to latest possible version, with "native" Superstring #713
Draft
mauricioszabo
wants to merge
106
commits into
master
Choose a base branch
from
feature/latest-electron-native-superstring
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Bump electron to latest possible version, with "native" Superstring #713
mauricioszabo
wants to merge
106
commits into
master
from
feature/latest-electron-native-superstring
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re/latest-electron
…tron-native-superstring
…tron-native-superstring
…tron-native-superstring
…tron-native-superstring
…tron-native-superstring
…tron-native-superstring
…tron-native-superstring
7 tasks
…tron-native-superstring
This reverts commit 05c50ca.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #484
Basically, the same code except that we're now using the native version of Superstring. This is to avoid slowdowns on files with too many lines.
Basically, this brings the time to a KeyDown event on files with 15k lines from 80ms (WASM Superstring) to 10ms (Native, this PR)
Currently, Electron 27.0.0
Bugs I found:
Uncaught TypeError: Cannot read properties of undefined (reading '0')
Update on keymap error - fixed via pulsar-edit/atom-keymap@3a9a9b4
With NAPI superstring, I also found this error on line
231
ofautocomplete-plus/lib/subsequence-provider.js
:This probably can be solved by not re-setting the score at the builtin provider, or making a clone (which we probably should be doing anyway)