Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 管理者からのお知らせ コンポーネントを実装した #77

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

laminne
Copy link
Member

@laminne laminne commented Sep 1, 2024

What does this PR do?

close #76

  • 時刻の相対表示コンポーネントの実装 (Time)
  • お知らせコンポーネントの実装 (Announce)
  • 翻訳ファイルを更新

Additional information

  • radix-iconを導入しました

Copy link
Contributor

@m1sk9 m1sk9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

フロントエンドエンジニアではないので, コンポーネントについてはあまり見れていません.


肝心のデザインについて: アイコンのサイズがテキストと合っていないことでかなり歪な印象があるので合わせるべきだと思います.

CleanShot 2024-09-01 at 22 32 53@2x

app/components/Time.tsx Outdated Show resolved Hide resolved
app/components/Time.tsx Outdated Show resolved Hide resolved
app/components/Announce.tsx Outdated Show resolved Hide resolved
app/components/Announce.tsx Outdated Show resolved Hide resolved
app/components/Announce.tsx Outdated Show resolved Hide resolved
app/components/Time.tsx Outdated Show resolved Hide resolved
app/components/Time.tsx Show resolved Hide resolved
app/components/Time.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: 管理者からのお知らせ コンポーネントを実装する
3 participants