admin: allow configuring GOP size workaround (fix #800)

Signed-off-by: Varun Patil <[email protected]>
pulsejet · Sep 29, 2023 · 2bb0f30 · 2bb0f30
1 parent 47a4ea7
commit 2bb0f30
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 3 deletions.
diff --git a/lib/Service/BinExt.php b/lib/Service/BinExt.php
@@ -170,6 +170,7 @@ public static function getGoVodConfig($local = false)
             'nvencScale' => Util::getSystemConfig('memories.vod.nvenc.scale'),
 
             'useTranspose' => Util::getSystemConfig('memories.vod.use_transpose'),
+            'useGopSize' => Util::getSystemConfig('memories.vod.use_gop_size'),
         ];
 
         if (!$local) {

diff --git a/lib/SystemConfigDefault.php b/lib/SystemConfigDefault.php
@@ -39,6 +39,7 @@
 
     // Extra streaming configuration
     'memories.vod.use_transpose' => false,
+    'memories.vod.use_gop_size' => false,
 
     // Paths to ffmpeg and ffprobe binaries
     'memories.vod.ffmpeg' => '',

diff --git a/src/components/admin/AdminTypes.ts b/src/components/admin/AdminTypes.ts
@@ -28,6 +28,7 @@ export type ISystemConfig = {
   'memories.vod.nvenc.scale': string;
 
   'memories.vod.use_transpose': boolean;
+  'memories.vod.use_gop_size': boolean;
 
   enabledPreviewProviders: string[];
   preview_max_x: number;

diff --git a/src/components/admin/sections/VideoAccel.vue b/src/components/admin/sections/VideoAccel.vue
@@ -106,9 +106,9 @@
         )
       }}
       <br />
-      <b>{{
-        t('memories', 'Enable the following option only if you have incorrectly oriented videos during playback.')
-      }}</b>
+      <b>
+        {{ t('memories', 'Try this option only if you have incorrectly oriented videos during playback.') }}
+      </b>
 
       <NcCheckboxRadioSwitch
         :disabled="!enableTranscoding"
@@ -118,6 +118,19 @@
       >
         {{ t('memories', 'Enable streaming transpose workaround') }}
       </NcCheckboxRadioSwitch>
+
+      {{ t('memories', 'Some NVENC devices have issues with force_key_frames.') }}
+      <br />
+      <b>{{ t('memories', 'Try this option only if you use NVENC and have issues with video playback.') }}</b>
+
+      <NcCheckboxRadioSwitch
+        :disabled="!enableTranscoding"
+        :checked.sync="config['memories.vod.use_gop_size']"
+        @update:checked="update('memories.vod.use_gop_size')"
+        type="switch"
+      >
+        {{ t('memories', 'Enable streaming GOP size workaround') }}
+      </NcCheckboxRadioSwitch>
     </p>
   </div>
 </template>