New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add separate categories for "live photos" and "panoramas" and support for 360 PhotoSphere viewer #1357

Open

jovanbulck wants to merge 3 commits into pulsejet:master from jovanbulck:photosphere

Contributor

jovanbulck commented Nov 28, 2024

Add the following features:

separate API and category in the "explore" menu for live photos and panoramas cf Panorama Sidebar Menu #676
- includes a heuristic to identify "panoramas" based on >= 3:1 aspect ratio
full integration with Photo Sphere Viewer JavaScript library cf Integration with Photosphere viewer #1036 and Photo Sphere Viewer #931
- this can be opened from a new "open in PhotoSphere" button in the image viewer
- Tested this on mobile and desktop on my end.

Possible further improvements:

only show the "open in PhotoSphere" button for pictures that we labeled as "panoramas"?
parse the XMP metadata to discover actual photospheres, even if they are < 3:1? This is what the files/photosphere NC app seems to do. In principle, this could be done server side and cached in the oc_memories table, but not all panorama pictures include XMP data afaik.

jovanbulck added 3 commits

November 28, 2024 00:59


          feat: add panorama and live photo views

a1d38f8

Fixes pulsejet#676


          feat: add photosphere viewer integration

6bfcaf4

Fixes pulsejet#1036


          photosphere: hide close button when pane is open

5eb311e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet