Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add per-group and skip cleanup options #803

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

akhil1508
Copy link
Contributor

  • For tens of thousands of users on an instance, running the index command is a must before enabling the app
  • Sometimes, need to re-run for a particular group so added group option
  • Also cleanup itself takes a few minutes and when running per-user, it wastes a lot of time, so added skip-cleanup option that defaults to false

@akhil1508
Copy link
Contributor Author

@pulsejet FYI, let me know if these changes are good :)

@pulsejet pulsejet merged commit a9a25a9 into pulsejet:master Sep 8, 2023
1 check failed
@pulsejet
Copy link
Owner

pulsejet commented Sep 8, 2023

Thanks @akhil1508. BTW you can run make php-lint after make dev-setup to fix lint issues in the future.

For tens of thousands of users on an instance, running the index command is a must before enabling the app

Are you really running this with this many users? I'm curious about performance; never tested it beyond two users myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants