Fix binary signing (#1296)

Fixes binary signing for Node binaries and darwin-arm64.
pulumi · Jan 16, 2025 · 730b8c1 · 730b8c1
1 parent d905280
commit 730b8c1
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 0 deletions.
diff --git a/provider-ci/internal/pkg/templates/bridged-provider/.github/workflows/build_provider.yml b/provider-ci/internal/pkg/templates/bridged-provider/.github/workflows/build_provider.yml
@@ -49,6 +49,11 @@ jobs:
           submodules: #{{ .Config.CheckoutSubmodules }}#
           #{{- end }}#
           persist-credentials: false
+      # Without ldid cross-compiling Node binaries on a Linux worker intended to work on darwin-arm64 fails to sign the
+      # binaries properly and they do not work as expected. See https://github.com/pulumi/pulumi-awsx/issues/1490
+      - uses: MOZGIII/install-ldid-action@v1
+        with:
+          tag: v2.1.5-procursus2
       - name: Setup tools
         uses: ./.github/actions/setup-tools
         with:

diff --git a/provider-ci/test-providers/acme/.github/workflows/build_provider.yml b/provider-ci/test-providers/acme/.github/workflows/build_provider.yml
@@ -36,6 +36,11 @@ jobs:
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
           persist-credentials: false
+      # Without ldid cross-compiling Node binaries on a Linux worker intended to work on darwin-arm64 fails to sign the
+      # binaries properly and they do not work as expected. See https://github.com/pulumi/pulumi-awsx/issues/1490
+      - uses: MOZGIII/install-ldid-action@v1
+        with:
+          tag: v2.1.5-procursus2
       - name: Setup tools
         uses: ./.github/actions/setup-tools
         with:

diff --git a/provider-ci/test-providers/aws/.github/workflows/build_provider.yml b/provider-ci/test-providers/aws/.github/workflows/build_provider.yml
@@ -45,6 +45,11 @@ jobs:
         with:
           submodules: true
           persist-credentials: false
+      # Without ldid cross-compiling Node binaries on a Linux worker intended to work on darwin-arm64 fails to sign the
+      # binaries properly and they do not work as expected. See https://github.com/pulumi/pulumi-awsx/issues/1490
+      - uses: MOZGIII/install-ldid-action@v1
+        with:
+          tag: v2.1.5-procursus2
       - name: Setup tools
         uses: ./.github/actions/setup-tools
         with:

diff --git a/provider-ci/test-providers/cloudflare/.github/workflows/build_provider.yml b/provider-ci/test-providers/cloudflare/.github/workflows/build_provider.yml
@@ -36,6 +36,11 @@ jobs:
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
           persist-credentials: false
+      # Without ldid cross-compiling Node binaries on a Linux worker intended to work on darwin-arm64 fails to sign the
+      # binaries properly and they do not work as expected. See https://github.com/pulumi/pulumi-awsx/issues/1490
+      - uses: MOZGIII/install-ldid-action@v1
+        with:
+          tag: v2.1.5-procursus2
       - name: Setup tools
         uses: ./.github/actions/setup-tools
         with:

diff --git a/provider-ci/test-providers/docker/.github/workflows/build_provider.yml b/provider-ci/test-providers/docker/.github/workflows/build_provider.yml
@@ -36,6 +36,11 @@ jobs:
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
           persist-credentials: false
+      # Without ldid cross-compiling Node binaries on a Linux worker intended to work on darwin-arm64 fails to sign the
+      # binaries properly and they do not work as expected. See https://github.com/pulumi/pulumi-awsx/issues/1490
+      - uses: MOZGIII/install-ldid-action@v1
+        with:
+          tag: v2.1.5-procursus2
       - name: Setup tools
         uses: ./.github/actions/setup-tools
         with:

diff --git a/provider-ci/test-providers/eks/.github/workflows/build_provider.yml b/provider-ci/test-providers/eks/.github/workflows/build_provider.yml
@@ -36,6 +36,11 @@ jobs:
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
           persist-credentials: false
+      # Without ldid cross-compiling Node binaries on a Linux worker intended to work on darwin-arm64 fails to sign the
+      # binaries properly and they do not work as expected. See https://github.com/pulumi/pulumi-awsx/issues/1490
+      - uses: MOZGIII/install-ldid-action@v1
+        with:
+          tag: v2.1.5-procursus2
       - name: Setup tools
         uses: ./.github/actions/setup-tools
         with: