Skip to content

Commit

Permalink
Remove duplicated 'Does the PR' (#879)
Browse files Browse the repository at this point in the history
Our schema comparison comments annoyingly have two headers:

<img width="529" alt="image"
src="https://github.com/pulumi/ci-mgmt/assets/1454008/b97e52ab-6915-42c1-a91f-c8a85cae3530">

Example in aws:
pulumi/pulumi-aws#3758 (comment)
Example in cloudflare:
pulumi/pulumi-cloudflare#713 (comment)

This is because they are defined both in CI jobs and in schema-tools
[here](https://github.com/pulumi/schema-tools/blob/bc3dae99a9ab5d2ad52f4c1029f35b65248a0118/internal/cmd/compare.go#L302).
This PR removes the duplication.
  • Loading branch information
mikhailshilkov authored Apr 12, 2024
2 parents 49f197a + 5c632c9 commit b5479f3
Show file tree
Hide file tree
Showing 14 changed files with 0 additions and 42 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,6 @@
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
comment_tag: schemaCheck
message: >+
### Does the PR have any schema changes?


${{ env.SCHEMA_CHANGES }}


Expand Down
3 changes: 0 additions & 3 deletions provider-ci/test-workflows/aws/.github/workflows/master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -287,9 +287,6 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
comment_tag: schemaCheck
message: >+
### Does the PR have any schema changes?
${{ env.SCHEMA_CHANGES }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -219,9 +219,6 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
comment_tag: schemaCheck
message: >+
### Does the PR have any schema changes?
${{ env.SCHEMA_CHANGES }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -224,9 +224,6 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
comment_tag: schemaCheck
message: >+
### Does the PR have any schema changes?
${{ env.SCHEMA_CHANGES }}
Expand Down
3 changes: 0 additions & 3 deletions provider-ci/test-workflows/aws/.github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -238,9 +238,6 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
comment_tag: schemaCheck
message: >+
### Does the PR have any schema changes?
${{ env.SCHEMA_CHANGES }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -245,9 +245,6 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
comment_tag: schemaCheck
message: >+
### Does the PR have any schema changes?
${{ env.SCHEMA_CHANGES }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -276,9 +276,6 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
comment_tag: schemaCheck
message: >+
### Does the PR have any schema changes?
${{ env.SCHEMA_CHANGES }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -215,9 +215,6 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
comment_tag: schemaCheck
message: >+
### Does the PR have any schema changes?
${{ env.SCHEMA_CHANGES }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -229,9 +229,6 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
comment_tag: schemaCheck
message: >+
### Does the PR have any schema changes?
${{ env.SCHEMA_CHANGES }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -239,9 +239,6 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
comment_tag: schemaCheck
message: >+
### Does the PR have any schema changes?
${{ env.SCHEMA_CHANGES }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -289,9 +289,6 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
comment_tag: schemaCheck
message: >+
### Does the PR have any schema changes?
${{ env.SCHEMA_CHANGES }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,6 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
comment_tag: schemaCheck
message: >+
### Does the PR have any schema changes?
${{ env.SCHEMA_CHANGES }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -242,9 +242,6 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
comment_tag: schemaCheck
message: >+
### Does the PR have any schema changes?
${{ env.SCHEMA_CHANGES }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -252,9 +252,6 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
comment_tag: schemaCheck
message: >+
### Does the PR have any schema changes?
${{ env.SCHEMA_CHANGES }}
Expand Down

0 comments on commit b5479f3

Please sign in to comment.