Skip to content

Commit

Permalink
Allow missing resource docs for Tier2+ providers (#1379)
Browse files Browse the repository at this point in the history
This PR changes all Tier2+ providers to allow missing resource docs when
running a provider upgrade. This is a common issue which happens and we
have to manually work around.

Fixes pulumi/upgrade-provider#303

Tier 1 providers are exempt as the config is explicitly false there:
pulumi/pulumi-gcp#2971
pulumi/pulumi-aws#5193
pulumi/pulumi-azure#3003
pulumi/pulumi-azuread#1877
  • Loading branch information
VenelinMartinov authored Feb 12, 2025
1 parent a9530f0 commit bebe923
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion provider-ci/internal/pkg/templates/defaults.config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -240,4 +240,4 @@ clean-github-workflows: true
autoMergeProviderUpgrades: true

# Whether we allow missing docs in the provider.
allowMissingDocs: false
allowMissingDocs: true
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
username: pulumi-bot
automerge: true
target-version: ${{ steps.target_version.outputs.version }}
allow-missing-docs: false
allow-missing-docs: true
- name: Comment on upgrade issue if automated PR failed
if: steps.upgrade_provider.outcome == 'failure'
shell: bash
Expand Down
1 change: 1 addition & 0 deletions provider-ci/test-providers/aws/.ci-mgmt.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ plugins:
kind: converter
# Use `pulumi convert` for translating examples from TF to Pulumi.
pulumiConvert: 1
allowMissingDocs: false
goBuildParallelism: 2
actions:
preTest:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
username: pulumi-bot
automerge: true
target-version: ${{ steps.target_version.outputs.version }}
allow-missing-docs: false
allow-missing-docs: true
- name: Comment on upgrade issue if automated PR failed
if: steps.upgrade_provider.outcome == 'failure'
shell: bash
Expand Down

0 comments on commit bebe923

Please sign in to comment.