Skip to content

Commit

Permalink
Show which patch failed (#807)
Browse files Browse the repository at this point in the history
When calling make upstream that fails on applying a patch, I would love
too see immediately which patch failed. This helps fix that one.
  • Loading branch information
t0yv0 authored Feb 9, 2024
1 parent ec32cf0 commit d2220e0
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ start_rebase() {
echo "Applying $patch"
if ! git am --3way "$patch"; then
echo
echo "Failed to apply patch. Please run 'make upstream.rebase FROM=$TAG' where '$TAG' allows the patch set to apply cleanly"
echo "Failed to apply ${patch}. Please run 'make upstream.rebase FROM=$TAG' where '$TAG' allows the patch set to apply cleanly"
echo
exit 1
fi
Expand Down Expand Up @@ -145,7 +145,7 @@ apply() {
if ! git apply --3way "$patch"; then
cat <<EOF
make "$1"' failed to apply a patch. This is because there is a conflict between
make "$1"' failed to apply ${patch}. This is because there is a conflict between
the checked out version of upstream and the patch set. To resolve this conflict
run:
Expand Down
4 changes: 2 additions & 2 deletions provider-ci/test-workflows/aws/scripts/upstream.sh
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ start_rebase() {
echo "Applying $patch"
if ! git am --3way "$patch"; then
echo
echo "Failed to apply patch. Please run 'make upstream.rebase FROM=$TAG' where '$TAG' allows the patch set to apply cleanly"
echo "Failed to apply ${patch}. Please run 'make upstream.rebase FROM=$TAG' where '$TAG' allows the patch set to apply cleanly"
echo
exit 1
fi
Expand Down Expand Up @@ -145,7 +145,7 @@ apply() {
if ! git apply --3way "$patch"; then
cat <<EOF
make "$1"' failed to apply a patch. This is because there is a conflict between
make "$1"' failed to apply ${patch}. This is because there is a conflict between
the checked out version of upstream and the patch set. To resolve this conflict
run:
Expand Down
4 changes: 2 additions & 2 deletions provider-ci/test-workflows/cloudflare/scripts/upstream.sh
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ start_rebase() {
echo "Applying $patch"
if ! git am --3way "$patch"; then
echo
echo "Failed to apply patch. Please run 'make upstream.rebase FROM=$TAG' where '$TAG' allows the patch set to apply cleanly"
echo "Failed to apply ${patch}. Please run 'make upstream.rebase FROM=$TAG' where '$TAG' allows the patch set to apply cleanly"
echo
exit 1
fi
Expand Down Expand Up @@ -145,7 +145,7 @@ apply() {
if ! git apply --3way "$patch"; then
cat <<EOF
make "$1"' failed to apply a patch. This is because there is a conflict between
make "$1"' failed to apply ${patch}. This is because there is a conflict between
the checked out version of upstream and the patch set. To resolve this conflict
run:
Expand Down
4 changes: 2 additions & 2 deletions provider-ci/test-workflows/docker/scripts/upstream.sh
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ start_rebase() {
echo "Applying $patch"
if ! git am --3way "$patch"; then
echo
echo "Failed to apply patch. Please run 'make upstream.rebase FROM=$TAG' where '$TAG' allows the patch set to apply cleanly"
echo "Failed to apply ${patch}. Please run 'make upstream.rebase FROM=$TAG' where '$TAG' allows the patch set to apply cleanly"
echo
exit 1
fi
Expand Down Expand Up @@ -145,7 +145,7 @@ apply() {
if ! git apply --3way "$patch"; then
cat <<EOF
make "$1"' failed to apply a patch. This is because there is a conflict between
make "$1"' failed to apply ${patch}. This is because there is a conflict between
the checked out version of upstream and the patch set. To resolve this conflict
run:
Expand Down

0 comments on commit d2220e0

Please sign in to comment.