Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excludes dependabot on schema check details,closes #1272 #1273

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Excludes dependabot on schema check details,closes #1272 #1273

merged 1 commit into from
Jan 8, 2025

Conversation

rshade
Copy link
Contributor

@rshade rshade commented Jan 7, 2025 •
edited
Loading

This should correct the following error:

Run thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b
  
No comment has been found with asked pattern. Creating a new comment.
Error: Resource not accessible by integration - https://docs.github.com/rest/issues/comments#create-an-issue-comment

@rshade rshade requested a review from danielrbradley January 7, 2025 19:43
danielrbradley
danielrbradley reviewed Jan 7, 2025
View reviewed changes
native-provider-ci/src/steps.ts Outdated
@@ -654,7 +654,7 @@ export function CommentSchemaChangesOnPR(provider: string): Step {
return {};
}
return {
if: "github.event_name == 'pull_request'",
if: "github.event_name == 'pull_request' && github.actor != 'dependabot[bot]' && github.actor != 'dependabot'",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there two variations?

Copy link
Contributor Author

@rshade rshade Jan 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependabot's actor values are dependabot[bot] (for Dependabot GitHub-native) and dependabot (legacy). We can probably get away with one: pulumi/pulumi-kubernetes-ingress-nginx#82 native. Sorry I hit the button to fast on the first reply

danielrbradley
danielrbradley approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also do this in the provider-ci side too to match.

@rshade rshade force-pushed the exclude-dependabot branch from a793751 to 8351034 Compare January 8, 2025 14:58
@rshade rshade requested a review from danielrbradley January 8, 2025 14:59
@rshade
Copy link
Contributor Author

rshade commented Jan 8, 2025

@danielrbradley I re-requested your review because I added in providers, and trimmed it down to just && github.actor != 'dependabot[bot]'

danielrbradley
danielrbradley approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rshade rshade added this pull request to the merge queue Jan 8, 2025
Merged via the queue into master with commit bab0493 Jan 8, 2025
7 checks passed
@rshade rshade deleted the exclude-dependabot branch January 8, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielrbradley danielrbradley danielrbradley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rshade @danielrbradley