Rename tfgen to codegen #1279
Rename tfgen to codegen #1279
Conversation
|
This change is part of the following stack: Change managed by git-spice. |
t0yv0
changed the title
t0yv0
force-pushed
the
t0yv0/generalize-codegen-binary
branch
from
9d74113 to
9d43ff9
Compare
| @@ -1,17 +1,17 @@ | |||
| name: Download the tfgen binary | |||
| description: Downloads the tfgen binary to `bin/`. | |||
| name: Download the code generator binary | |||
There was a problem hiding this comment.
These should just be cosmetic renames.
| @@ -9,7 +9,11 @@ PROVIDER_PATH := provider/v#{{ .Config.MajorVersion }}# | |||
| PROVIDER_PATH := provider | |||
| #{{- end }}# | |||
| VERSION_PATH := $(PROVIDER_PATH)/pkg/version.Version | |||
| #{{- if .Config.NoUpstream }}# | |||
| TFGEN := pulumi-gen-$(PACK) | |||
There was a problem hiding this comment.
Nit: we could also rename TFGEN to something like SCHEMA_GEN or PROVIDER_GEN
| @@ -9,7 +9,11 @@ PROVIDER_PATH := provider/v#{{ .Config.MajorVersion }}# | |||
| PROVIDER_PATH := provider | |||
| #{{- end }}# | |||
| VERSION_PATH := $(PROVIDER_PATH)/pkg/version.Version | |||
| #{{- if .Config.NoUpstream }}# | |||
| TFGEN := pulumi-gen-$(PACK) | |||
| #{{- else }}# | |||
| TFGEN := pulumi-tfgen-$(PACK) | |||
There was a problem hiding this comment.
Should we be renaming tfgen everywhere to just gen?
There was a problem hiding this comment.
It might be safer to keep the binary name as tfgen for now until we can be sure that renaming the binary won't break other hardcoded workflows.
There was a problem hiding this comment.
Should we be renaming tfgen everywhere to just gen
Possible in principle with some source migrations but that'd take some care to roll out, I opt for the easier branch here for now.
t0yv0
force-pushed
the
t0yv0/generalize-codegen-binary
branch
from
b97be93 to
762aa5a
Compare
For NoUpstream providers typically the terraform bits are not relevant, so code generator binary should be called `pulumi-gen-provider` not `pulumi-tfgen-provider`.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
It used to be called pulumi-tfgen-${PROVIDER} but will be called pulumi-gen-${PROVIDER}
t0yv0
force-pushed
the
t0yv0/generalize-codegen-binary
branch
from
762aa5a to
a116210
Compare
For NoUpstream providers typically the terraform bits are not relevant, so code generator binary should be called
pulumi-gen-providernotpulumi-tfgen-provider.