Share build_provider_cmd in the Makefile #1280
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build_provider_cmd
is generalized to be a function taking the destination path and performing all platform-specific and platform local builds of the provider in the bridged provider Makefile.Specifically:
build_provider_cmd receives
$(1)
that expands to the target path for the binary, such as bin/pulumi-resource-random.It also receives the environment GOOS and GOARCH specifying which platform to build for.
If those are not specified it should build for the default platform.
Previously the go provider builder was duplicated across provider: and
darwin-amd64/$(PROVIDER)
targets.This is intended to be used in providers such as pulumi-awsx to override the recipe for building the target-specific binary in one place and provide a recipe for building a Node-based binary.