Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share build_provider_cmd in the Makefile #1280

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Jan 10, 2025

build_provider_cmd is generalized to be a function taking the destination path and performing all platform-specific and platform local builds of the provider in the bridged provider Makefile.

Specifically:

build_provider_cmd receives $(1) that expands to the target path for the binary, such as bin/pulumi-resource-random.
It also receives the environment GOOS and GOARCH specifying which platform to build for.
If those are not specified it should build for the default platform.

Previously the go provider builder was duplicated across provider: and darwin-amd64/$(PROVIDER) targets.

This is intended to be used in providers such as pulumi-awsx to override the recipe for building the target-specific binary in one place and provide a recipe for building a Node-based binary.

@t0yv0 t0yv0 requested a review from rquitales January 10, 2025 23:08
@t0yv0
Copy link
Member Author

t0yv0 commented Jan 13, 2025

This change is part of the following stack:

Change managed by git-spice.

@t0yv0 t0yv0 merged commit 5af3ebd into master Jan 13, 2025
6 checks passed
@t0yv0 t0yv0 deleted the t0yv0/share-build-provider-cmd branch January 13, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants