Configure credentials for release verification #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This permits providers such as pulumi-awsx to simply state this in .ci-mgmt.yaml:
aws: true
And have release verification authorized for AWS.
Without this change release verification does not work as it lacks credentials.
11 tasks
rquitales
approved these changes
Jan 14, 2025
t0yv0
added a commit
to pulumi/pulumi-awsx
that referenced
this pull request
Jan 14, 2025
This change swaps out custom GitHub actions workflows with workflows managed centrally in pulumi/ci-mgmt that are standard across Pulumi provider repositories. Fixes pulumi/ci-mgmt#1191 Depends on pulumi/ci-mgmt#1287 Builds on top of pulumi/ci-mgmt#1275 using Bridged Makefile for this provider. - [x] run all tests - [x] `cd awsx && yarn test` is running via a .mk extender - [x] `cd awsx-classic/tests && yarn && yarn run build && yarn run mocha $$(find bin -name '*.spec.js')` also known as istanbul-tests, these were not run in CI prior to the change - [x] examples_legacy were not run as acceptance tests intentionally per README - [x] examples are running - [x] recover weekly-pulumi-update.yml - [x] recover awsx-upgrade-aws.yml - [x] ensure renovate can update the repo - [x] ensure post-release verification - [x] perform an alpha release - [x] verify in each language the SDKs got versioned and usable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This permits providers such as pulumi-awsx to simply state this in .ci-mgmt.yaml:
And have release verification authorized for AWS.
Without this change release verification does not work as it lacks credentials.
The template bits got copied from
ci-mgmt/provider-ci/internal/pkg/templates/bridged-provider/.github/workflows/test.yml
Line 74 in 3beca11