Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a monorepo example using Nx #1604

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Adds a monorepo example using Nx #1604

merged 1 commit into from
Mar 1, 2024

Conversation

julienp
Copy link
Contributor

@julienp julienp commented Feb 28, 2024 •
edited
Loading

Fixes #1605

@julienp julienp marked this pull request as ready for review February 28, 2024 13:15
@julienp julienp requested a review from a team February 29, 2024 12:31
PollRobots
PollRobots approved these changes Mar 1, 2024
View reviewed changes
Copy link

@PollRobots PollRobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor nit

nx-monorepo/README.md Outdated
- infra: Pulumi program that uses the s3folder and website ComponentResources to deploy a website
```

To deploy the latest version of the website, we need to respect the certain dependencies:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would word this as

To deploy the latest version of the website, we need to respect the following dependencies:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@julienp julienp force-pushed the julienp/nx-monorepo branch from 23e96c5 to f5c660d Compare March 1, 2024 07:58
@julienp julienp merged commit 77fb5aa into master Mar 1, 2024
50 of 51 checks passed
@julienp julienp deleted the julienp/nx-monorepo branch March 1, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PollRobots PollRobots PollRobots approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an example to show usage of Nx with workspaces
2 participants
@julienp @PollRobots