-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[program-gen] Emit invoke options and invoke output options in generated programs #1586
Merged
+325
−122
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
930dbec
Implement InvokeOptionsBuilder and InvokeOutputOptionsBuilder
Zaid-Ajaj 6de93d6
Emit invoke options and invoke output options in generated programs
Zaid-Ajaj 50f66e7
lint
Zaid-Ajaj b634a0b
Handle relative traversals when shadowing parameter names
Zaid-Ajaj fcfa371
regen examples
Zaid-Ajaj cda98a7
Enable PreferOutputVersionedInvokes in program-gen tests and regenera…
Zaid-Ajaj 1c13cc0
simplify invokes inside range expressions
Zaid-Ajaj 44aae97
Embed the builder classes and simplify
Zaid-Ajaj 1cc06ee
Merge branch 'zaid/invoke-options-codegen' into zaid/invoke-options-p…
Zaid-Ajaj caa2209
use embedded builder for InvokeOutputOptions
Zaid-Ajaj 42260f1
Merge branch 'main' into zaid/invoke-options-program-gen
Zaid-Ajaj 3b1c858
Address comments
Zaid-Ajaj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
use embedded builder for InvokeOutputOptions
commit caa220982bd4efc1699fc8deb49d0f02a260a8fc
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe tweak this to just check the length once?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done ✅