Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #3309

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix tests #3309

wants to merge 2 commits into from

Conversation

blampe
Copy link
Contributor

@blampe blampe commented Nov 11, 2024

The nginx:1.7.9 image is 9-years-old and we've recently had issues pulling it.

Tests on master time out after this:

 +  kubernetes:core/v1:Pod nginx creating (1s) warning: Failed: Failed to pull image "nginx:1.7.9": failed to pull and unpack image "docker.io/library/nginx:1.7.9": no signatures
 +  kubernetes:core/v1:Pod nginx creating (1s) warning: Failed: Error: ErrImagePull
@ updating....
 +  kubernetes:core/v1:Pod nginx creating (2s) warning: Failed: Error: ImagePullBackOff

Even locally I'm not able to pull it:

❯ docker pull nginx:1.7.9
Error response from daemon: missing signature key

Various support articles suggest this is due to an older version of Docker, but I'm running v27.

Rather than attempt to debug this further, let's update these tests to use a more recent image which doesn't have this problem.

Update: the pull error was transient and probably had something to do with this:

[DEPRECATION NOTICE] Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Suggest the author of docker.io/library/nginx:1.7.9 to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2. More information at https://docs.docker.com/go/deprecated-image-specs/

@blampe blampe added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Nov 11, 2024
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.06%. Comparing base (6865778) to head (b4b06e2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3309   +/-   ##
=======================================
  Coverage   41.06%   41.06%           
=======================================
  Files          85       85           
  Lines       12740    12740           
=======================================
  Hits         5232     5232           
  Misses       7119     7119           
  Partials      389      389           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blampe blampe marked this pull request as draft November 12, 2024 20:42
Copy link
Contributor

@EronWright EronWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks, I too hit upon this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants