-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pulumiTest Integration tests #2052
Conversation
https://github.com/pulumi/pulumi-terraform-bridge/blob/master/pkg/tests/cross-tests/input_check.go#L132 already using it. Whatever is most convenient. |
Yeah, absolutely, it's where I adapted this from. I was wondering if we should abstract the part about bridging a TF provider and hooking it up to pulumiTest for wider use in the bridge. |
Yes, it would. We have a few ProgramTest tests but rebuilding the underlying provider is a bit of a hassle. But it would be really useful to have a quick stencil way to define a quick schema, program in one place and exercise it end to end, under Pulumi and/or TF, with debugging attached by default. Streamlining this would help contributors adding integration tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really helpful to me.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2052 +/- ##
==========================================
+ Coverage 61.20% 61.27% +0.06%
==========================================
Files 337 339 +2
Lines 45177 45075 -102
==========================================
- Hits 27651 27619 -32
+ Misses 16005 15936 -69
+ Partials 1521 1520 -1 ☔ View full report in Codecov by Sentry. |
This reverts commit 6d81799.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Ian Wahbe <[email protected]>
…pulumi-terraform-bridge into vvm/pulumiTest_integration_tests
This refactors the cross-tests to expose an integration test module
pulCheck
for use outside of cross-tests.It allows us to easily write integration tests where we specify a TF schema, which gets bridged and use the pulumiTest framework for the test itself.